[GitHub] [airflow] mik-laj commented on a change in pull request #19452: Moved hive macros to the providers package

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #19452:
URL: https://github.com/apache/airflow/pull/19452#discussion_r744245495



##########
File path: airflow/macros/__init__.py
##########
@@ -22,7 +22,7 @@
 
 import dateutil  # noqa
 
-from airflow.macros import hive  # noqa
+from airflow.providers.apache.hive.macros import hive  # noqa

Review comment:
       We should not import modules from the airflow.providers package in the top-level code as this creates hard dependencies. Now everyone must have Apache Hive provider installed to use the `airflow.macros` module.
   
   We should extend [airflow.providers_manager](https://github.com/apache/airflow/blob/main/airflow/providers_manager.py) with macro support. It should look similar to support macros in plugin_manager.
   https://github.com/apache/airflow/blob/main/airflow/plugins_manager.py#L428-L458
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org