You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/03/30 06:28:02 UTC

[GitHub] [echarts] pissang opened a new pull request #14553: feat(animation): add animaiton configuration in resize

pissang opened a new pull request #14553:
URL: https://github.com/apache/echarts/pull/14553


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Add animation config in `ECharts#resize`
   
   ### Fixed issues
   
   https://github.com/apache/echarts/issues/13923
   
   
   ## Details
   
   ### Before: What was the problem?
   
   Resize animation is removed by default in 5.0
   
   ### After: How is it fixed in this PR?
   
   Add a config so animation can still be enabled when resizing.
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [x] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   interface ResizeOpts {
     // other exists opts.
     
     animation: {
        duration: number
        easing: AnimationEasing
        delay: number
     }
   }
   
   ### Related test cases or examples to use the new APIs
   
   myChart.resize({
     animation: {
         duration: 300,
         easing: 'cubicInOut'
     }
   });
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14553: feat(animation): add animaiton configuration in resize

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14553:
URL: https://github.com/apache/echarts/pull/14553#issuecomment-809948982


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.
   
   Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14553: feat(animation): add animaiton configuration in resize

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14553:
URL: https://github.com/apache/echarts/pull/14553


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14553: feat(animation): add animaiton configuration in resize

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14553:
URL: https://github.com/apache/echarts/pull/14553#issuecomment-809953278


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org