You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/28 08:54:16 UTC
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3188: [Improve][Connector-V2][Redis] Support redis cluster connection & user authentication
EricJoy2048 commented on code in PR #3188:
URL: https://github.com/apache/incubator-seatunnel/pull/3188#discussion_r1007819225
##########
docs/en/connector-v2/sink/Redis.md:
##########
@@ -121,3 +131,7 @@ simple:
### 2.2.0-beta 2022-09-26
- Add Redis Sink Connector
+
+### 2.3.0-beta 2022-10-25
Review Comment:
`### next version`
##########
docs/en/connector-v2/sink/Redis.md:
##########
@@ -121,3 +131,7 @@ simple:
### 2.2.0-beta 2022-09-26
- Add Redis Sink Connector
+
+### 2.3.0-beta 2022-10-25
+
+- Support redis cluster mode connection and user authentication
Review Comment:
`- [Improve/BugFix] xxxxxxxx ([prid](https://github.com/apache/incubator-seatuxxxnnel/pull/prid))`
##########
docs/en/connector-v2/source/Redis.md:
##########
@@ -67,10 +69,18 @@ redis data types, support `key` `hash` `list` `set` `zset`
> Each element in the sorted set will be sent downstream as a single row of data
> For example, the value of sorted set is `[tyrantlucier, CalvinKirs]`, the data received downstream are `tyrantlucifer` and `CalvinKirs` and only two message will be received.
+### user [String]
Review Comment:
This doc has the same problem as `sink/Redis.md`
##########
docs/en/connector-v2/sink/Redis.md:
##########
@@ -75,10 +77,18 @@ Redis data types, support `key` `hash` `list` `set` `zset`
- zset
> Each data from upstream will be added to the configured zset key with a weight of 1. So the order of data in zset is based on the order of data consumption.
+### user [String]
Review Comment:
`string` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org