[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request #880: HDDS-3327. Fix s3api create bucket BUCKET_NOT_FOUND when enable acl.

[GitBox <gi...@apache.org>]

vivekratnavel commented on a change in pull request #880:
URL: https://github.com/apache/hadoop-ozone/pull/880#discussion_r416791423



##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
##########
@@ -103,6 +107,13 @@ private OzoneClient getClient(OzoneConfiguration config) throws IOException {
           throw S3_AUTHINFO_CREATION_ERROR;
         }
 
+      } else if (isAclenable) {
+        if (v4RequestParser.getAwsAccessId() != null) {
+          String awsAccessId = v4RequestParser.getAwsAccessId();

Review comment:
       Move this statement before `if` and use awsAccessId to check not null in if
   
   ```
   String awsAccessId = v4RequestParser.getAwsAccessId();
   if (awsAccessId != null) {
   ```

##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
##########
@@ -76,6 +78,8 @@ public void destory() throws IOException {
 
   private OzoneClient getClient(OzoneConfiguration config) throws IOException {
     try {
+      Boolean isAclenable = config.getBoolean(

Review comment:
       Rename variable to `isAclEnabled` for consistency in casing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org