[GitHub] [solr] epugh commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

["epugh (via GitHub)" <gi...@apache.org>]

epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1085229423


##########
solr/solrj/src/test/org/apache/solr/client/solrj/response/TermsResponseTest.java:
##########
@@ -31,16 +35,19 @@ public class TermsResponseTest extends EmbeddedSolrServerTestBase {
 
   @BeforeClass
   public static void beforeClass() throws Exception {
-    initCore();
+    solrClientTestRule.startSolr(LuceneTestCase.createTempDir("solrhome"));

Review Comment:
   Does this need the "solrhome" parameter?   When I see it, it makes me think it's important somehow..   I saw we also have the use of `.createTempDir()` with no name, is that better in the sense of conveying that it isn't important to have a named directory?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org