[GitHub] [pulsar] jerrypeng commented on a change in pull request #4520: [REST API Doc]Sink API refinement

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #4520: [REST API Doc]Sink API refinement
URL: https://github.com/apache/pulsar/pull/4520#discussion_r292985085
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinksBase.java
 ##########
 @@ -85,19 +139,78 @@ public void registerSink(final @PathParam("tenant") String tenant,
     @PUT
     @ApiOperation(value = "Updates a Pulsar Sink currently running in cluster mode")
     @ApiResponses(value = {
-            @ApiResponse(code = 403, message = "The requester doesn't have admin permissions"),
-            @ApiResponse(code = 400, message = "Invalid request (function doesn't exist, etc.)"),
-            @ApiResponse(code = 200, message = "Pulsar Function successfully updated")
+            @ApiResponse(code = 400, message = "Invalid request (sink doesn't exist, update contains no change, etc.)"),
+            @ApiResponse(code = 200, message = "Pulsar Sink successfully updated"),
+            @ApiResponse(code = 401, message = "Client is not authorized to perform operation"),
+            @ApiResponse(code = 404, message = "The provided `sinkName` is not a sink"),
 
 Review comment:
   ```suggestion
               @ApiResponse(code = 404, message = "Sink doesn't exist"),
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services