You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/02/27 14:13:34 UTC
Review Request 74326: RANGER-4096 : "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74326/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4096
https://issues.apache.org/jira/browse/RANGER-4096
Repository: ranger
Description
-------
Behaviour in React UI:
"Show all users" option is not available although if the no. of user added to a group is more than 100 and they are clipped in the show user prompt.
Behaviour in backbone JS UI:
In the similar case in old UI the show all users option is available.
Steps to reproduce:
# create a group "{random}_group".
# Add more than 100 users with "{random}_group" as group and click on the users column of "{random}_group" group from group tables.
# Its clipping the users list after 100 but not showing the option to show all users.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx 62ec1d8ad
Diff: https://reviews.apache.org/r/74326/diff/1/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things :-
- CRUD operation for Group Module
- Group Associate User modal
- Group Listing Table
Thanks,
Brijesh Bhalala
Re: Review Request 74326: RANGER-4096 : "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74326/#review225227
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On Feb. 28, 2023, 10:20 a.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74326/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2023, 10:20 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4096
> https://issues.apache.org/jira/browse/RANGER-4096
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Behaviour in React UI:
>
> "Show all users" option is not available although if the no. of user added to a group is more than 100 and they are clipped in the show user prompt.
>
> Behaviour in backbone JS UI:
>
> In the similar case in old UI the show all users option is available.
>
>
>
> Steps to reproduce:
> # create a group "{random}_group".
> # Add more than 100 users with "{random}_group" as group and click on the users column of "{random}_group" group from group tables.
> # Its clipping the users list after 100 but not showing the option to show all users.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx 62ec1d8ad
>
>
> Diff: https://reviews.apache.org/r/74326/diff/2/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things :-
> - CRUD operation for Group Module
> - Group Associate User modal
> - Group Listing Table
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74326: RANGER-4096 : "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74326/#review225306
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On March 29, 2023, 3:08 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74326/
> -----------------------------------------------------------
>
> (Updated March 29, 2023, 3:08 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4096
> https://issues.apache.org/jira/browse/RANGER-4096
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Behaviour in React UI:
>
> "Show all users" option is not available although if the no. of user added to a group is more than 100 and they are clipped in the show user prompt.
>
> Behaviour in backbone JS UI:
>
> In the similar case in old UI the show all users option is available.
>
>
>
> Steps to reproduce:
> # create a group "{random}_group".
> # Add more than 100 users with "{random}_group" as group and click on the users column of "{random}_group" group from group tables.
> # Its clipping the users list after 100 but not showing the option to show all users.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx 3c253544fbbf903af4536f5834a45a8459a8c7b3
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx 62ec1d8ad743b388b76371620afd8d8432ad09cc
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 28e9a36bd3abe0f77142141d5980a20d2bbe8994
>
>
> Diff: https://reviews.apache.org/r/74326/diff/4/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things :-
> - CRUD operation for Group Module
> - Group Associate User modal
> - Group Listing Table
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74326: RANGER-4096 : "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74326/#review225313
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On March 29, 2023, 3:08 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74326/
> -----------------------------------------------------------
>
> (Updated March 29, 2023, 3:08 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4096
> https://issues.apache.org/jira/browse/RANGER-4096
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Behaviour in React UI:
>
> "Show all users" option is not available although if the no. of user added to a group is more than 100 and they are clipped in the show user prompt.
>
> Behaviour in backbone JS UI:
>
> In the similar case in old UI the show all users option is available.
>
>
>
> Steps to reproduce:
> # create a group "{random}_group".
> # Add more than 100 users with "{random}_group" as group and click on the users column of "{random}_group" group from group tables.
> # Its clipping the users list after 100 but not showing the option to show all users.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx 3c253544fbbf903af4536f5834a45a8459a8c7b3
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx 62ec1d8ad743b388b76371620afd8d8432ad09cc
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 28e9a36bd3abe0f77142141d5980a20d2bbe8994
>
>
> Diff: https://reviews.apache.org/r/74326/diff/4/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things :-
> - CRUD operation for Group Module
> - Group Associate User modal
> - Group Listing Table
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74326: RANGER-4096 : "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74326/
-----------------------------------------------------------
(Updated March 29, 2023, 3:08 p.m.)
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4096
https://issues.apache.org/jira/browse/RANGER-4096
Repository: ranger
Description
-------
Behaviour in React UI:
"Show all users" option is not available although if the no. of user added to a group is more than 100 and they are clipped in the show user prompt.
Behaviour in backbone JS UI:
In the similar case in old UI the show all users option is available.
Steps to reproduce:
# create a group "{random}_group".
# Add more than 100 users with "{random}_group" as group and click on the users column of "{random}_group" group from group tables.
# Its clipping the users list after 100 but not showing the option to show all users.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx 3c253544fbbf903af4536f5834a45a8459a8c7b3
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx 62ec1d8ad743b388b76371620afd8d8432ad09cc
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 28e9a36bd3abe0f77142141d5980a20d2bbe8994
Diff: https://reviews.apache.org/r/74326/diff/4/
Changes: https://reviews.apache.org/r/74326/diff/3-4/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things :-
- CRUD operation for Group Module
- Group Associate User modal
- Group Listing Table
Thanks,
Brijesh Bhalala
Re: Review Request 74326: RANGER-4096 : "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74326/
-----------------------------------------------------------
(Updated March 20, 2023, 1:47 p.m.)
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4096
https://issues.apache.org/jira/browse/RANGER-4096
Repository: ranger
Description
-------
Behaviour in React UI:
"Show all users" option is not available although if the no. of user added to a group is more than 100 and they are clipped in the show user prompt.
Behaviour in backbone JS UI:
In the similar case in old UI the show all users option is available.
Steps to reproduce:
# create a group "{random}_group".
# Add more than 100 users with "{random}_group" as group and click on the users column of "{random}_group" group from group tables.
# Its clipping the users list after 100 but not showing the option to show all users.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx 3c253544f
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx 62ec1d8ad
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 28e9a36bd
Diff: https://reviews.apache.org/r/74326/diff/3/
Changes: https://reviews.apache.org/r/74326/diff/2-3/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things :-
- CRUD operation for Group Module
- Group Associate User modal
- Group Listing Table
Thanks,
Brijesh Bhalala
Re: Review Request 74326: RANGER-4096 : "show all users" button is not available in the show users prompt of groups table even if the users list is longer than 100.
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74326/
-----------------------------------------------------------
(Updated Feb. 28, 2023, 10:20 a.m.)
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4096
https://issues.apache.org/jira/browse/RANGER-4096
Repository: ranger
Description
-------
Behaviour in React UI:
"Show all users" option is not available although if the no. of user added to a group is more than 100 and they are clipped in the show user prompt.
Behaviour in backbone JS UI:
In the similar case in old UI the show all users option is available.
Steps to reproduce:
# create a group "{random}_group".
# Add more than 100 users with "{random}_group" as group and click on the users column of "{random}_group" group from group tables.
# Its clipping the users list after 100 but not showing the option to show all users.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx 62ec1d8ad
Diff: https://reviews.apache.org/r/74326/diff/2/
Changes: https://reviews.apache.org/r/74326/diff/1-2/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things :-
- CRUD operation for Group Module
- Group Associate User modal
- Group Listing Table
Thanks,
Brijesh Bhalala