You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/10 16:28:03 UTC
[GitHub] [arrow] lwhite1 opened a new pull request, #13114: MINOR[JAVA] indicate absolute path is required in docs
lwhite1 opened a new pull request, #13114:
URL: https://github.com/apache/arrow/pull/13114
Because maven is setup to run the tests in a temp folder, the path provided to the native libraries must be absolute or the tests will fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #13114: MINOR: [Java] Indicate absolute path is required in docs
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #13114: MINOR: [Java] Indicate absolute path is required in docs
URL: https://github.com/apache/arrow/pull/13114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lwhite1 commented on a diff in pull request #13114: MINOR: [Java] Indicate absolute path is required in docs
Posted by GitBox <gi...@apache.org>.
lwhite1 commented on code in PR #13114:
URL: https://github.com/apache/arrow/pull/13114#discussion_r869693776
##########
docs/source/developers/java/building.rst:
##########
@@ -78,6 +78,7 @@ We can build these manually or we can use `Archery`_ to build them using a Docke
Building JNI Libraries on MacOS
-------------------------------
+Note: If you are building on Apple silicon, be sure to use a JDK version that was compiled for that architecture.
Review Comment:
I'm not sure its canonical, but I. will add a link to the Azul download page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13114: MINOR[JAVA] indicate absolute path is required in docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13114:
URL: https://github.com/apache/arrow/pull/13114#issuecomment-1122656229
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13114: MINOR: [Java] Indicate absolute path is required in docs
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13114:
URL: https://github.com/apache/arrow/pull/13114#discussion_r869519327
##########
docs/source/developers/java/building.rst:
##########
@@ -78,6 +78,7 @@ We can build these manually or we can use `Archery`_ to build them using a Docke
Building JNI Libraries on MacOS
-------------------------------
+Note: If you are building on Apple silicon, be sure to use a JDK version that was compiled for that architecture.
Review Comment:
nit:
```suggestion
Note: If you are building on Apple Silicon, be sure to use a JDK version that was compiled for that architecture.
```
is there a canonical JDK distribution we can link to or no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13114: MINOR: [Java] Indicate absolute path is required in docs
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13114:
URL: https://github.com/apache/arrow/pull/13114#discussion_r870249432
##########
docs/source/developers/java/building.rst:
##########
@@ -78,6 +78,7 @@ We can build these manually or we can use `Archery`_ to build them using a Docke
Building JNI Libraries on MacOS
-------------------------------
+Note: If you are building on Apple Silicon, be sure to use a JDK version that was compiled for that architecture. See, for example: https://www.azul.com/downloads/?os=macos&architecture=arm-64-bit&package=jdk.
Review Comment:
```suggestion
Note: If you are building on Apple Silicon, be sure to use a JDK version that was compiled for that architecture. See, for example, the `Azul JDK <https://www.azul.com/downloads/?os=macos&architecture=arm-64-bit&package=jdk>`_.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13114: MINOR: [Java] Indicate absolute path is required in docs
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13114:
URL: https://github.com/apache/arrow/pull/13114#issuecomment-1126658698
Benchmark runs are scheduled for baseline = 7a955f07b3472a36d9174eb71883f8f9c33083ae and contender = e5e4901eb84224f353193bb4f512d60e82e40aa9. e5e4901eb84224f353193bb4f512d60e82e40aa9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/53ace4fa7e464725adfa1de0ff7a72cd...573f0c88e5754f029c9ff1753267ad92/)
[Failed :arrow_down:0.43% :arrow_up:0.08%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3deada4f13044a2d9f1a3680c80fcbec...a1cbef06d9584ed2bd12127492f82953/)
[Finished :arrow_down:1.07% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/29bfe49c406545ae93205d6c68d8ce1a...2f5851429dc842ac9b9f509d752ec1ea/)
[Finished :arrow_down:0.12% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1ee5f735665e456f8f2de04a87ed6117...175f8b087bcc4d849f25060274bad0f0/)
Buildkite builds:
[Finished] [`e5e4901e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/748)
[Finished] [`e5e4901e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/745)
[Finished] [`e5e4901e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/735)
[Finished] [`e5e4901e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/750)
[Finished] [`7a955f07` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/747)
[Failed] [`7a955f07` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/744)
[Finished] [`7a955f07` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/734)
[Finished] [`7a955f07` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/749)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org