You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/10/16 14:56:34 UTC

Review Request 39389: AMBARI-13445 : LDAP related properties in ranger-admin-site should be derived from similar properties in ranger

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39389/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.


Bugs: AMBARI-13445
    https://issues.apache.org/jira/browse/AMBARI-13445


Repository: ambari


Description
-------

Adding change to map LDAP related derived properties from base properties.


Diffs
-----

  ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 499c058 
  ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ca77837 
  ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py fafe1ec 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml bb6ec00 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml f180957 

Diff: https://reviews.apache.org/r/39389/diff/


Testing
-------

Tested property mapping from below base properties to derived properties

| Base Property | Derived property |
| ranger.usersync.ldap.url | ranger.ldap.url, ranger.ldap.ad.url |
| ranger.usersync.ldap.user.searchfilter | ranger.ldap.user.searchfilter, ranger.ldap.ad.user.searchfilter |
| ranger.usersync.group.searchbase | ranger.ldap.group.searchbase |
| ranger.usersync.group.searchfilter | ranger.ldap.group.searchfilter |
| ranger.usersync.ldap.binddn | ranger.ldap.bind.dn, ranger.ldap.ad.bind.dn | 
| ranger.usersync.ldap.ldapbindpassword | ranger.ldap.bind.password, ranger.ldap.ad.bind.password | 

Unit test report:
----------------------------------------------------------------------
Ran 267 tests in 6.570s

OK
----------------------------------------------------------------------
Total run:846
Total errors:0
Total failures:0
OK


Thanks,

Gautam Borad


Re: Review Request 39389: AMBARI-13445 : LDAP related properties in ranger-admin-site should be derived from similar properties in ranger

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39389/#review102929
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On Oct. 16, 2015, 12:56 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39389/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 12:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-13445
>     https://issues.apache.org/jira/browse/AMBARI-13445
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Adding change to map LDAP related derived properties from base properties.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/usersync-properties.xml 499c058 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py ca77837 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py fafe1ec 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml bb6ec00 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml f180957 
> 
> Diff: https://reviews.apache.org/r/39389/diff/
> 
> 
> Testing
> -------
> 
> Tested property mapping from below base properties to derived properties
> 
> | Base Property | Derived property |
> | ranger.usersync.ldap.url | ranger.ldap.url, ranger.ldap.ad.url |
> | ranger.usersync.ldap.user.searchfilter | ranger.ldap.user.searchfilter, ranger.ldap.ad.user.searchfilter |
> | ranger.usersync.group.searchbase | ranger.ldap.group.searchbase |
> | ranger.usersync.group.searchfilter | ranger.ldap.group.searchfilter |
> | ranger.usersync.ldap.binddn | ranger.ldap.bind.dn, ranger.ldap.ad.bind.dn | 
> | ranger.usersync.ldap.ldapbindpassword | ranger.ldap.bind.password, ranger.ldap.ad.bind.password | 
> 
> Unit test report:
> ----------------------------------------------------------------------
> Ran 267 tests in 6.570s
> 
> OK
> ----------------------------------------------------------------------
> Total run:846
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>