You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/15 22:24:42 UTC
[jira] [Commented] (BEAM-1492) Avoid potential issue in ASM 5.0
[ https://issues.apache.org/jira/browse/BEAM-1492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868687#comment-15868687 ]
ASF GitHub Bot commented on BEAM-1492:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/2014
[BEAM-1492] Upgrade bytebuddy to 1.6.8 to jump past asm 5.0
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
There is a suspected bug in asm 5.0 that is considered the likely root cause of a bug sbt/sbt-assembly#205 (see [this comment](https://github.com/sbt/sbt-assembly/issues/205#issuecomment-279964607)) that carried over to [Gearpump](https://issues.apache.org/jira/browse/GEARPUMP-236). This commit upgrades us to depend on bytebuddy 1.6.8 that uses asm 5.2 in which those derivative bugs have cleared up.
I have not found a direct reference to what the issue is, precisely, but the dependency effect is nil because bytebuddy is fully shaded (no deps) so we might as well jump past any problematic version eagerly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam bytebuddy-asm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2014.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2014
----
commit 3e4c05c3449064e7f032a48b98551a73d71a5bbb
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-02-15T22:02:38Z
Upgrade bytebuddy to 1.6.8 to jump past asm 5.0
There is a suspected bug in asm 5.0 that is considered the likely root cause of
a bug sbt-assembly [1] that carried over to Gearpump [2]. This commit upgrades
us to depend on asm 5.2 in which those derivative bugs have cleared up.
I have not found a direct reference to what the issue is, precisely, but
the dependency effect of this is extremely small and these are libraries
that are useful to keep current.
[1] https://github.com/sbt/sbt-assembly/issues/205#issuecomment-279964607
[2] https://issues.apache.org/jira/browse/GEARPUMP-236
----
> Avoid potential issue in ASM 5.0
> --------------------------------
>
> Key: BEAM-1492
> URL: https://issues.apache.org/jira/browse/BEAM-1492
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
> There is a suspected bug in asm 5.0 that is considered the likely root cause of a [bug sbt-assembly|https://github.com/sbt/sbt-assembly/issues/205#issuecomment-279964607] that carried over to [GEARPUMP-236]. I have not found a direct reference to what the issue is, precisely, but the dependency effect of this is extremely small and these are libraries that are useful to keep current. And if/when Gearpump runner lands on master this will avoid any diamond dep issues.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)