You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/01/12 17:12:18 UTC
[GitHub] [netbeans] neilcsmith-net opened a new pull request #3449: [NETBEANS-6347] Revert "UI support for disabled actions."
neilcsmith-net opened a new pull request #3449:
URL: https://github.com/apache/netbeans/pull/3449
This reverts commit a401cec52837866eaf67e7a60bddd71da89730a0.
This commit appears to be the root cause of NETBEANS-6347 - adding global and project custom actions is completely broken in Maven.
I did ask about this on #3016 I'm not sure what the desired effect in the UI is. I looked into trying to keep the renderer and disabled button, but the renderer needs adapting to handle empty added actions, and the disabled button doesn't seem to be hooked up to anything?!
Think we need to revert and rethink, as it's causing major issues for users. cc @sdedic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3449: [NETBEANS-6347] Revert "UI support for disabled actions."
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3449:
URL: https://github.com/apache/netbeans/pull/3449#issuecomment-1014629079
Closing in favour of #3454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net closed pull request #3449: [NETBEANS-6347] Revert "UI support for disabled actions."
Posted by GitBox <gi...@apache.org>.
neilcsmith-net closed pull request #3449:
URL: https://github.com/apache/netbeans/pull/3449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3449: [NETBEANS-6347] Revert "UI support for disabled actions."
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3449:
URL: https://github.com/apache/netbeans/pull/3449#issuecomment-1011287742
Sure! Will wait until branching on Monday latest. I did my best not to revert! But it was getting to the stage I'd pulled out almost all the changes anyway. Think it needs a separation of no-goals / custom actions from disabled in this particular context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3449: [NETBEANS-6347] Revert "UI support for disabled actions."
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3449:
URL: https://github.com/apache/netbeans/pull/3449#issuecomment-1012093974
OK, I believe I have a quick fix that will allow to disable (standard) actions; a proper fix requires a small extension to the ActionMapping definition, as the `disabled` state is now under-represented (as an absence of any goal). So it both complicates interaction with new actions and also prevents from disable-enable when one would expect the action retains the former definition, but it does not (goals are cleared).
Similar with Gradle. I would track that as another bug + attempt to fix for the next release (or backport if the result would not be that disruptive).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3449: [NETBEANS-6347] Revert "UI support for disabled actions."
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3449:
URL: https://github.com/apache/netbeans/pull/3449#issuecomment-1011279754
Please hold on with this one till Friday, I have the bug on my list but needed to finish with vscode-ext first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists