You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/31 04:04:26 UTC

[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3231: [Improve][Core][spark-starter] Fix the command line generated by SparkStarter

TaoZex commented on PR #3231:
URL: https://github.com/apache/incubator-seatunnel/pull/3231#issuecomment-1296510550

   > > Did you have tested? From reading the code, I found that you are removing the above parameter, not the below. The parameters above are for spark, and the parameters below are for seatunnel. ![image](https://user-images.githubusercontent.com/32387433/198920557-386f1b25-fac4-4655-8018-f12ac66a418c.png)
   > 
   > +1, please do the integration test. CC @TaoZex
   
   Thanks for the review.This image is the first submission of the code. Next, I will do the integration test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org