You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "Baunsgaard (via GitHub)" <gi...@apache.org> on 2026/06/25 11:30:45 UTC
[PR] [BWARE] Tighten MatrixBlock API and extract aggregateUnary specialization [systemds]
Baunsgaard opened a new pull request, #2513:
URL: https://github.com/apache/systemds/pull/2513
Refactors the MatrixBlock surface so quantile/sort entry points are sealed against accidental overrides, sparseToDense is fluent, and the unary-aggregate dispatch lives in its own helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BWARE] Tighten MatrixBlock quantile/sort API surface [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard merged PR #2513:
URL: https://github.com/apache/systemds/pull/2513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BWARE] Tighten MatrixBlock API and extract aggregateUnary specialization [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2513:
URL: https://github.com/apache/systemds/pull/2513#issuecomment-4798965079
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2513?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `3.15789%` with `92 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 71.52%. Comparing base ([`abddc1d`](https://app.codecov.io/gh/apache/systemds/commit/abddc1d5091ff50af43a4073bb14ebbbf6232906?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ca87aa8`](https://app.codecov.io/gh/apache/systemds/commit/ca87aa81d9913cd213326c9756aefbb5501cfe14?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2513?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/matrix/data/LibAggregateUnarySpecialization.java](https://app.codecov.io/gh/apache/systemds/pull/2513?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fmatrix%2Fdata%2FLibAggregateUnarySpecialization.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvbWF0cml4L2RhdGEvTGliQWdncmVnYXRlVW5hcnlTcGVjaWFsaXphdGlvbi5qYXZh) | 0.00% | [79 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/sysds/runtime/matrix/data/LibMatrixMult.java](https://app.codecov.io/gh/apache/systemds/pull/2513?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fmatrix%2Fdata%2FLibMatrixMult.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvbWF0cml4L2RhdGEvTGliTWF0cml4TXVsdC5qYXZh) | 0.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/sysds/runtime/matrix/data/MatrixBlock.java](https://app.codecov.io/gh/apache/systemds/pull/2513?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fmatrix%2Fdata%2FMatrixBlock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvbWF0cml4L2RhdGEvTWF0cml4QmxvY2suamF2YQ==) | 33.33% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../sysds/runtime/compress/CompressedMatrixBlock.java](https://app.codecov.io/gh/apache/systemds/pull/2513?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fsysds%2Fruntime%2Fcompress%2FCompressedMatrixBlock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3N5c2RzL3J1bnRpbWUvY29tcHJlc3MvQ29tcHJlc3NlZE1hdHJpeEJsb2NrLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2513 +/- ##
============================================
- Coverage 71.56% 71.52% -0.04%
+ Complexity 49112 49111 -1
============================================
Files 1575 1576 +1
Lines 189784 189870 +86
Branches 37232 37248 +16
============================================
- Hits 135822 135810 -12
- Misses 43471 43573 +102
+ Partials 10491 10487 -4
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/systemds/pull/2513?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org