You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by emirot <gi...@git.apache.org> on 2018/04/06 04:06:16 UTC
[GitHub] spark pull request #20990: Fix typo in docstring
GitHub user emirot opened a pull request:
https://github.com/apache/spark/pull/20990
Fix typo in docstring
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emirot/spark kinesis_stream_example_typo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20990.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20990
----
commit a8e0fb495805771ad9b4b11416ea369b2344cf5a
Author: Nolan Emirot <no...@...>
Date: 2018-04-06T04:04:36Z
Fix typo in docstring
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20990: Fix typo in Python docstring kinesis example
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20990
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20990: Fix typo in Python docstring kinesis example
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20990
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20990: Fix typo in Python docstring kinesis example
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20990
let's do them in a batch if possible .. it doesn't have to be perfect. one close look should find more typos. Let's fix PR title to `[MINOR][DOCS] ...` and fill up the PR description as well.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20990: Fix typo in Python docstring kinesis example
Posted by emirot <gi...@git.apache.org>.
Github user emirot commented on the issue:
https://github.com/apache/spark/pull/20990
@felixcheung
The other examples look fine, if I come across a typo or issue I will create another PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20990: Fix typo in Python docstring kinesis example
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20990
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20990: Fix typo in Python docstring kinesis example
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20990
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org