You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/05/08 13:49:50 UTC

svn commit: r1889677 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java

Author: tilman
Date: Sat May  8 13:49:50 2021
New Revision: 1889677

URL: http://svn.apache.org/viewvc?rev=1889677&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java?rev=1889677&r1=1889676&r2=1889677&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/common/PDPageLabels.java Sat May  8 13:49:50 2021
@@ -99,22 +99,25 @@ public class PDPageLabels implements COS
     
     private void findLabels(PDNumberTreeNode node) throws IOException 
     {
+        List<PDNumberTreeNode> kids = node.getKids();
         if (node.getKids() != null) 
         {
-            List<PDNumberTreeNode> kids = node.getKids();
             for (PDNumberTreeNode kid : kids) 
             {
                 findLabels(kid);
             }
         }
-        else if (node.getNumbers() != null) 
+        else
         {
-            Map<Integer, COSObjectable> numbers = node.getNumbers();
-            for (Entry<Integer, COSObjectable> i : numbers.entrySet())
+            Map<Integer,COSObjectable> numbers = node.getNumbers();
+            if (numbers != null)
             {
-                if(i.getKey() >= 0)
+                for (Entry<Integer, COSObjectable> i : numbers.entrySet())
                 {
-                    labels.put(i.getKey(), (PDPageLabelRange) i.getValue());
+                    if (i.getKey() >= 0)
+                    {
+                        labels.put(i.getKey(), (PDPageLabelRange) i.getValue());
+                    }
                 }
             }
         }