You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/26 22:11:09 UTC

[GitHub] [flink] stevenzwu commented on a change in pull request #13784: [FLINK-19689][connectors/common] API improvements to the Sources.

stevenzwu commented on a change in pull request #13784:
URL: https://github.com/apache/flink/pull/13784#discussion_r512299554



##########
File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/splitreader/SplitReader.java
##########
@@ -57,4 +57,11 @@
 	 * {@link #fetch()}.
 	 */
 	void wakeUp();
+
+	/**
+	 * Close the split reader.
+	 *
+	 * @throws Exception if closing the split reader failed.
+	 */
+	default void close() throws Exception {}

Review comment:
       I was about to ask for this :) otherwise, we may have resource/file leak for unclosed files in Iceberg source.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org