You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/07/31 17:30:13 UTC

[GitHub] [incubator-livy] o-shevchenko opened a new pull request #189: [LIVY-616] Livy Server discovery

o-shevchenko opened a new pull request #189: [LIVY-616] Livy Server discovery
URL: https://github.com/apache/incubator-livy/pull/189
 
 
   ## What changes were proposed in this pull request?
   
   Implement Livy Server discovery mechanism based on ZooKeeper. And provide convenient API for clients to get LivyServer URL without explicitly set it manually by "livy.server.host" property. Then we also can use it in LivyClientBuilder to set URL automatically. It will provide a more easy way for configuration. We don't need to set "livy.server.host" or "zeppelin.livy.url" manually in a case when we don't know where Livy Server will be started.
   
   I have separated ZooKeeper logic from StateStore logic, as a result, we can use new ZooKeeperManager just to communicate with ZooKeeper and build new logic based on it (as I do for DiscoveryManager and ZooKeeperStateStore)
   
   ## How was this patch tested?
   Added unit tests for new functionality. Didn't expose new API yet for subsequent testing.
   
   What the best way to add new API?
   I see the couple of ways to do that:
   1. Add it to LivyConf - in this case, we need to create DiscoveryManager in LivyConf which is not good.
   2. Add it to LivyClient interface and set some variable during creating client via LivyClientBuilder.
   
   Please, advise.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services