You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2019/12/27 04:10:02 UTC
[GitHub] [incubator-brpc] jamesge commented on a change in pull request
#1002: fix two bugs about rdma
jamesge commented on a change in pull request #1002: fix two bugs about rdma
URL: https://github.com/apache/incubator-brpc/pull/1002#discussion_r361576885
##########
File path: src/brpc/server.cpp
##########
@@ -1055,16 +1055,16 @@ int Server::StartInternal(const butil::ip_t& ip,
return -1;
}
std::unique_ptr<rdma::RdmaCommunicationManager> rh;
+ butil::EndPoint internal_point = _listen_addr;
+ internal_point.port = _options.internal_port;
if (_options.use_rdma) {
- rh.reset(rdma::RdmaCommunicationManager::Listen(_listen_addr));
+ rh.reset(rdma::RdmaCommunicationManager::Listen(internal_point));
Review comment:
这属于功能上的改变了？相关的文档需要修改么？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org