[jira] Updated: (AMQ-1629) wildcards don't work in networkconnector excludeDestinations

["Swen Moczarski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/activemq/browse/AMQ-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Swen Moczarski updated AMQ-1629:
--------------------------------

    Attachment: DemandForwardingBridgeFilterTest.java
                DemandForwardingBridgeSupport.java.patch

I see two problems with the current implementation (version 5.2)  for excluded- and dynamically-included destinations:

1. The type of the destination (queue, topic) is not distincted:
{code:xml}
<excludedDestinations> 

   <topic physicalName=">"/> 

</excludedDestinations>
{code}
Only topics should be excluded but all queues are also excluded.

2. An entry with a wildcard in the list has a side-effect on the following entries:
{code:xml}
<excludedDestinations>
   <queue physicalName="exclude"/>
</excludedDestinations>
<dynamicallyIncludedDestinations>
   <queue physicalName="foo.>"/>
   <queue physicalName="bar.x"/>
</dynamicallyIncludedDestinations>
{code} 
A message to {{bar.x}} will be blocked because of the wildcard in the first entry.

I've created a test case and a new patch. I would be happy for a review of test case and patch.

> wildcards don't work in networkconnector excludeDestinations 
> -------------------------------------------------------------
>
>                 Key: AMQ-1629
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1629
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 4.1.1, 5.0.0
>         Environment: linux
>            Reporter: Sridhar Komandur
>            Assignee: Rob Davies
>             Fix For: 5.3.0
>
>         Attachments: amq1629.txt, DemandForwardingBridgeFilterTest.java, DemandForwardingBridgeSupport.java.patch
>
>
> Version: 5.0 
> We have a simple setup to test excludedDestinations config ...We are using the broker and  example producer & consumer from the binary distribution (broker instances A & B are on different hosts 
> Setup: 
> producer --- A ---- B--- consumer 
> Broker A's activemq.xml has the following for NC config (everythingelse is the same as in the orig config file):
>     <networkConnectors> 
>       <networkConnector name="toB" uri="static://(tcp://B.foo.com:61616)"> 
>            <excludedDestinations> 
>                 <queue physicalName="TEST.>" /> 
>            </excludedDestinations> 
>      </networkConnector> 
>     </networkConnectors> 
> Issue: consumer attached to Broker B sees all the messages sent to TEST.FOO (the default messages generated by the producer)
> We noticed that none of the queue or topic wildcards work, only specific topic or queue names work in the exclusion. However, http://activemq.apache.org/networks-of-brokers.html states "N.B. You can use wildcards in inclusive , exclusive destination properties". Are we missing anything ? 
> Thanks 
> - Sridhar

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.