You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Juan Manuel Fresia <jf...@medallia.com> on 2018/01/10 17:56:19 UTC
Review Request 65076: Added ExclusionStrategy to Gson
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
Diffs
-----
src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
Diff: https://reviews.apache.org/r/65076/diff/1/
Testing
-------
Gradle verification/test target.
Thanks,
Juan Manuel Fresia
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/#review195154
-----------------------------------------------------------
Master (f6146eb) is red with this patch.
./build-support/jenkins/build.sh
+ 264 hidden modules
:processResources
:classes
:jar
:moreStartScripts
:startScripts
:distTar
:distZip
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processTestResources
:testClasses
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/StructDump.java:27: Using the '.*' form of import should be avoided - com.google.gson.*. [AvoidStarImport]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/StructDump.java:107: Line is longer than 100 characters (found 103). [LineLength]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/StructDump.java:119: switch without "default" clause. [MissingSwitchDefault]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 4m 10s
32 actionable tasks: 26 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 10, 2018, 5:56 p.m., Juan Manuel Fresia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65076/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 5:56 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
>
>
> Diff: https://reviews.apache.org/r/65076/diff/1/
>
>
> Testing
> -------
>
> Gradle verification/test target.
>
>
> Thanks,
>
> Juan Manuel Fresia
>
>
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/#review195159
-----------------------------------------------------------
Master (f6146eb) is red with this patch.
./build-support/jenkins/build.sh
:distTar
:distZip
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processTestResources
:testClasses
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain
:checkstyleTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/http/StructDump.java:113: Avoid unnecessary if..then..else statements when returning booleans
:pmdMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pmdMain'.
> 1 PMD rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 4m 29s
38 actionable tasks: 29 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 10, 2018, 6:18 p.m., Juan Manuel Fresia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65076/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 6:18 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
>
>
> Diff: https://reviews.apache.org/r/65076/diff/2/
>
>
> Testing
> -------
>
> Gradle verification/test target.
>
>
> Thanks,
>
> Juan Manuel Fresia
>
>
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/#review195484
-----------------------------------------------------------
Master (f6146eb) is red with this patch.
./build-support/jenkins/build.sh
Pass 2: Analyzing classes (323 / 333) - 96% complete
Pass 2: Analyzing classes (324 / 333) - 97% complete
Pass 2: Analyzing classes (325 / 333) - 97% complete
Pass 2: Analyzing classes (326 / 333) - 97% complete
Pass 2: Analyzing classes (327 / 333) - 98% complete
Pass 2: Analyzing classes (328 / 333) - 98% complete
Pass 2: Analyzing classes (329 / 333) - 98% complete
Pass 2: Analyzing classes (330 / 333) - 99% complete
Pass 2: Analyzing classes (331 / 333) - 99% complete
Pass 2: Analyzing classes (332 / 333) - 99% complete
Pass 2: Analyzing classes (333 / 333) - 100% complete
Done with analysis
:test
org.apache.aurora.scheduler.http.StructDumpTest > testTaskConfigDoesNotIncludeMetadata FAILED
java.lang.AssertionError at StructDumpTest.java:72
org.apache.aurora.scheduler.http.StructDumpTest > testTaskConfigFieldRename FAILED
java.lang.AssertionError at StructDumpTest.java:88
I0116 19:18:10.988 [ShutdownHook, SchedulerMain] Stopping scheduler services.
1080 tests completed, 2 failed, 1 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 7m 48s
45 actionable tasks: 36 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 16, 2018, 7:07 p.m., Juan Manuel Fresia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65076/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2018, 7:07 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65076/diff/4/
>
>
> Testing
> -------
>
> Gradle verification/test target.
>
>
> Thanks,
>
> Juan Manuel Fresia
>
>
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Juan Manuel Fresia <jf...@medallia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/#review195630
-----------------------------------------------------------
@ReviewBot retry
- Juan Manuel Fresia
On Jan. 16, 2018, 7:20 p.m., Juan Manuel Fresia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65076/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2018, 7:20 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added ExclusionStrategy to Gson formatter in structdump to hide trhift metadata fields such as "__isset_bitfield" and the "optionals" enum.
> Added a FieldNamingStrategy to rename "value_" and "setName_" fields to "value" and "key" on map formatting.
> Created test cases to cover the scenarios above.
>
> Signed-off-by: Juan Manuel Fresia <jfresia@medallia.com\>
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
> src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65076/diff/5/
>
>
> Testing
> -------
>
> Gradle verification/test target.
>
>
> Thanks,
>
> Juan Manuel Fresia
>
>
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/#review195659
-----------------------------------------------------------
Ship it!
Thanks for the patch! This is now on master
```console
$ git log -1 origin/master
commit 8a5dcac (HEAD -> master, origin/master, origin/HEAD)
Author: Juan Manuel Fresia <jf...@medallia.com>
Date: Wed Jan 17 15:02:26 2018 -0800
Added ExclusionStrategy to Gson formatter in structdump
This hides thrift metadata fields such as "__isset_bitfield"
and the "optionals" enum.
Added a FieldNamingStrategy to rename "value_" and "setName_"
fields to "value" and "key" on map formatting.
Reviewed at https://reviews.apache.org/r/65076/
```
- Bill Farner
On Jan. 17, 2018, 11:15 a.m., Juan Manuel Fresia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65076/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 11:15 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added ExclusionStrategy to Gson formatter in structdump to hide trhift metadata fields such as "__isset_bitfield" and the "optionals" enum.
> Added a FieldNamingStrategy to rename "value_" and "setName_" fields to "value" and "key" on map formatting.
> Created test cases to cover the scenarios above.
>
> Signed-off-by: Juan Manuel Fresia <jfresia@medallia.com\>
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
> src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65076/diff/6/
>
>
> Testing
> -------
>
> Gradle verification/test target.
>
>
> Thanks,
>
> Juan Manuel Fresia
>
>
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/#review195640
-----------------------------------------------------------
Ship it!
Master (f6146eb) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 17, 2018, 11:15 a.m., Juan Manuel Fresia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65076/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 11:15 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added ExclusionStrategy to Gson formatter in structdump to hide trhift metadata fields such as "__isset_bitfield" and the "optionals" enum.
> Added a FieldNamingStrategy to rename "value_" and "setName_" fields to "value" and "key" on map formatting.
> Created test cases to cover the scenarios above.
>
> Signed-off-by: Juan Manuel Fresia <jfresia@medallia.com\>
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
> src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65076/diff/6/
>
>
> Testing
> -------
>
> Gradle verification/test target.
>
>
> Thanks,
>
> Juan Manuel Fresia
>
>
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Juan Manuel Fresia <jf...@medallia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/
-----------------------------------------------------------
(Updated Jan. 17, 2018, 7:15 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Updated origin/master to fix rebase issue (?)
@ReviewBot retry
Repository: aurora
Description
-------
Added ExclusionStrategy to Gson formatter in structdump to hide trhift metadata fields such as "__isset_bitfield" and the "optionals" enum.
Added a FieldNamingStrategy to rename "value_" and "setName_" fields to "value" and "key" on map formatting.
Created test cases to cover the scenarios above.
Signed-off-by: Juan Manuel Fresia <jfresia@medallia.com\>
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/65076/diff/6/
Changes: https://reviews.apache.org/r/65076/diff/5-6/
Testing
-------
Gradle verification/test target.
Thanks,
Juan Manuel Fresia
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/#review195633
-----------------------------------------------------------
This patch does not apply cleanly against master (f6146eb), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 16, 2018, 11:20 a.m., Juan Manuel Fresia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65076/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2018, 11:20 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added ExclusionStrategy to Gson formatter in structdump to hide trhift metadata fields such as "__isset_bitfield" and the "optionals" enum.
> Added a FieldNamingStrategy to rename "value_" and "setName_" fields to "value" and "key" on map formatting.
> Created test cases to cover the scenarios above.
>
> Signed-off-by: Juan Manuel Fresia <jfresia@medallia.com\>
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
> src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65076/diff/5/
>
>
> Testing
> -------
>
> Gradle verification/test target.
>
>
> Thanks,
>
> Juan Manuel Fresia
>
>
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Juan Manuel Fresia <jf...@medallia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/
-----------------------------------------------------------
(Updated Jan. 16, 2018, 7:20 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Re-introducing changes (tests should pass now).
(@ReviewBot retry)
Repository: aurora
Description
-------
Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/65076/diff/5/
Changes: https://reviews.apache.org/r/65076/diff/4-5/
Testing
-------
Gradle verification/test target.
Thanks,
Juan Manuel Fresia
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Juan Manuel Fresia <jf...@medallia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/
-----------------------------------------------------------
(Updated Jan. 16, 2018, 7:07 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Added some basic testing: search for specific unwanted fields on the raw html output.
(@ReviewBot retry)
Repository: aurora
Description
-------
Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
Diffs (updated)
-----
src/test/java/org/apache/aurora/scheduler/http/StructDumpTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/65076/diff/4/
Changes: https://reviews.apache.org/r/65076/diff/3-4/
Testing
-------
Gradle verification/test target.
Thanks,
Juan Manuel Fresia
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/#review195167
-----------------------------------------------------------
Thanks for the patch!
Can you add a test to validate the final JSON form? That will be good insurance against breaking your usage in the future. `MnameTest.java` can serve as a guide for testing an HTTP endpoint.
- Bill Farner
On Jan. 10, 2018, 10:36 a.m., Juan Manuel Fresia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65076/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 10:36 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
>
>
> Diff: https://reviews.apache.org/r/65076/diff/3/
>
>
> Testing
> -------
>
> Gradle verification/test target.
>
>
> Thanks,
>
> Juan Manuel Fresia
>
>
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/#review195165
-----------------------------------------------------------
Master (f6146eb) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 10, 2018, 10:36 a.m., Juan Manuel Fresia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65076/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2018, 10:36 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
>
>
> Diff: https://reviews.apache.org/r/65076/diff/3/
>
>
> Testing
> -------
>
> Gradle verification/test target.
>
>
> Thanks,
>
> Juan Manuel Fresia
>
>
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Juan Manuel Fresia <jf...@medallia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/
-----------------------------------------------------------
(Updated Jan. 10, 2018, 6:36 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
@ReviewBot retry
Repository: aurora
Description
-------
Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
Diff: https://reviews.apache.org/r/65076/diff/3/
Changes: https://reviews.apache.org/r/65076/diff/2-3/
Testing
-------
Gradle verification/test target.
Thanks,
Juan Manuel Fresia
Re: Review Request 65076: Added ExclusionStrategy to Gson
Posted by Juan Manuel Fresia <jf...@medallia.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65076/
-----------------------------------------------------------
(Updated Jan. 10, 2018, 6:18 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Fix checkstyle @ReviewBot retry
Repository: aurora
Description
-------
Signed-off-by: Juan Manuel Fresia <jf...@medallia.com>
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/http/StructDump.java 1710e39f4fef9cba9d78cb097c889ac89bd04eb5
Diff: https://reviews.apache.org/r/65076/diff/2/
Changes: https://reviews.apache.org/r/65076/diff/1-2/
Testing
-------
Gradle verification/test target.
Thanks,
Juan Manuel Fresia