You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/10 18:36:32 UTC

[GitHub] icexelloss opened a new pull request #23279: [SPARK-26328][SQL] Use GenerateOrdering for group key comparision in WindowExec

icexelloss opened a new pull request #23279: [SPARK-26328][SQL] Use GenerateOrdering for group key comparision in WindowExec
URL: https://github.com/apache/spark/pull/23279
 
 
   ## What changes were proposed in this pull request?
   
   Per discussion here: https://github.com/apache/spark/pull/22305/commits/850541873df1101485a85632b85ba474dac67d56#r239312302
   
   It seems better and more standard to use GenerateOrdering for group key comparison.
   
   
   ## How was this patch tested?
   
   Existing tests.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org