You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2016/01/23 02:32:58 UTC
[jclouds] Fixes a NPE when null is expected. (#906)
https://issues.apache.org/jira/browse/JCLOUDS-1064
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/906
-- Commit Summary --
* Fixes a NPE when null is expected.
-- File Changes --
M apis/openstack-swift/src/main/java/org/jclouds/openstack/swift/v1/blobstore/RegionScopedSwiftBlobStore.java (8)
M blobstore/src/main/java/org/jclouds/blobstore/internal/BaseBlobStore.java (23)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/906.patch
https://github.com/jclouds/jclouds/pull/906.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/906
Re: [jclouds] Fixes a NPE when null is expected. (#906)
Posted by Andrew Gaul <no...@github.com>.
> String eTag = api.getObjectApi(regionId, mpu.containerName()).put(partName, payload);
> + if (eTag == null) {
Sorry I do not understand this. Why is the ETag nullable for a successful put? Otherwise we should raise an exception?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/906/files#r50626251
Re: [jclouds] Fixes a NPE when null is expected. (#906)
Posted by Zack Shoylev <no...@github.com>.
Closed #906.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/906#event-561946182
Re: [jclouds] Fixes a NPE when null is expected. (#906)
Posted by Zack Shoylev <no...@github.com>.
This might need some more work? I am not sure if we want to do additional retries, different behavior, or more tests.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/906#issuecomment-174104691
Re: [jclouds] Fixes a NPE when null is expected. (#906)
Posted by Zack Shoylev <no...@github.com>.
> String eTag = api.getObjectApi(regionId, mpu.containerName()).put(partName, payload);
> + if (eTag == null) {
That is the question. From https://issues.apache.org/jira/browse/JCLOUDS-1064
I thought it simply indicated (service-side?) failure, even with no fallback annotation on the swift put.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/906/files#r50748195