You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2015/09/02 04:16:23 UTC

[GitHub] spark pull request: [SPARK-9328] [WIP] [BRANCH-1.2] Add read timeo...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7653#discussion_r38493657
  
    --- Diff: network/common/src/main/java/org/apache/spark/network/util/TransportConf.java ---
    @@ -40,6 +40,11 @@ public int connectionTimeoutMs() {
         return conf.getInt("spark.shuffle.io.connectionTimeout", 120) * 1000;
       }
     
    +  /** Read timeout in milliseconds. Default 120 secs. */
    +  public int readTimeoutSeconds() {
    +    return conf.getInt("spark.shuffle.io.readTimeout", 120);
    --- End diff --
    
    This could use `TimeUtils.timeStringAsSec` for extra friendly configuration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org