You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by pc...@apache.org on 2026/09/22 09:38:30 UTC
(camel-k) 02/05: test(trait): name the synthetic Kit tests for what they actually assert
This is an automated email from the ASF dual-hosted git repository.
squakez pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel-k.git
commit b674a65554759241204e597ffedd8ac05c2959fb
Author: harshilv17 <ha...@gmail.com>
AuthorDate: Sun Sep 20 22:51:17 2026 +0530
test(trait): name the synthetic Kit tests for what they actually assert
---
pkg/trait/health_test.go | 4 ++--
pkg/trait/kamelets_test.go | 4 ++--
pkg/trait/knative_test.go | 10 +++++-----
pkg/trait/trait_types_test.go | 4 ++--
4 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/pkg/trait/health_test.go b/pkg/trait/health_test.go
index c9e9423c1..319617e1c 100644
--- a/pkg/trait/health_test.go
+++ b/pkg/trait/health_test.go
@@ -270,10 +270,10 @@ func createNominalHealthTrait(t *testing.T) (*healthTrait, *Environment) {
return trait, environment
}
-func TestApplyHealthTraitSyntheticKit(t *testing.T) {
+func TestApplyHealthTraitWithoutCatalog(t *testing.T) {
enabled := true
ht, environment := createNominalHealthTrait(t)
- // Simulate a synthetic Kit which has not catalog attached
+ // Simulate a Kit which has no catalog attached
environment.CamelCatalog = nil
ht.Enabled = ptr.To(true)
ht.LivenessProbeEnabled = &enabled
diff --git a/pkg/trait/kamelets_test.go b/pkg/trait/kamelets_test.go
index 9c0944b4c..c9e518e42 100644
--- a/pkg/trait/kamelets_test.go
+++ b/pkg/trait/kamelets_test.go
@@ -615,7 +615,7 @@ func templateOrFail(template map[string]interface{}) *v1.Template {
return &t
}
-func TestKameletSyntheticKitConditionTrue(t *testing.T) {
+func TestKameletWithoutCatalogConditionTrue(t *testing.T) {
trait, environment := createKameletsTestEnvironment(
"",
&v1.Kamelet{
@@ -660,7 +660,7 @@ func TestKameletSyntheticKitConditionTrue(t *testing.T) {
assert.Contains(t, kameletsBundle.Data, "timer-source.kamelet.yaml", "uri: timer:tick")
}
-func TestKameletSyntheticKitAutoConditionFalse(t *testing.T) {
+func TestKameletWithoutCatalogAutoConditionFalse(t *testing.T) {
trait, environment := createKameletsTestEnvironment(
"",
&v1.Kamelet{
diff --git a/pkg/trait/knative_test.go b/pkg/trait/knative_test.go
index cf53a1de6..5064f944b 100644
--- a/pkg/trait/knative_test.go
+++ b/pkg/trait/knative_test.go
@@ -1268,7 +1268,7 @@ func NewFakeEnvironment(t *testing.T, source v1.SourceSpec) Environment {
return environment
}
-func NewFakeEnvironmentForSyntheticKit(t *testing.T) Environment {
+func NewFakeEnvironmentForKitWithoutCatalog(t *testing.T) Environment {
t.Helper()
client, _ := newFakeClient("ns")
traitCatalog := NewCatalog(nil)
@@ -1513,16 +1513,16 @@ func fromCamelProperties(appProps map[string]string) (*knativeapi.CamelEnvironme
return &env, nil
}
-func TestKnativeSyntheticKitDefault(t *testing.T) {
- e := NewFakeEnvironmentForSyntheticKit(t)
+func TestKnativeKitWithoutCatalogDefault(t *testing.T) {
+ e := NewFakeEnvironmentForKitWithoutCatalog(t)
knTrait, _ := newKnativeTrait().(*knativeTrait)
ok, _, err := knTrait.Configure(&e)
require.NoError(t, err)
assert.False(t, ok)
}
-func TestKnativeSyntheticKitEnabled(t *testing.T) {
- e := NewFakeEnvironmentForSyntheticKit(t)
+func TestKnativeKitWithoutCatalogEnabled(t *testing.T) {
+ e := NewFakeEnvironmentForKitWithoutCatalog(t)
knTrait, _ := newKnativeTrait().(*knativeTrait)
knTrait.Enabled = ptr.To(true)
ok, _, err := knTrait.Configure(&e)
diff --git a/pkg/trait/trait_types_test.go b/pkg/trait/trait_types_test.go
index 653e0f73e..8c46b9f7e 100644
--- a/pkg/trait/trait_types_test.go
+++ b/pkg/trait/trait_types_test.go
@@ -125,14 +125,14 @@ func TestDetermineControllerStrategyAutoKnative(t *testing.T) {
assert.Equal(t, ControllerStrategyKnativeService, strategy)
}
-func TestDetermineControllerStrategySyntheticKitDefault(t *testing.T) {
+func TestDetermineControllerStrategyNonManagedBuildDefault(t *testing.T) {
e := createNonManagedBuildTestEnvironment(t, v1.TraitProfileKnative)
strategy, err := e.DetermineControllerStrategy()
require.NoError(t, err)
assert.Equal(t, DefaultControllerStrategy, strategy)
}
-func TestDetermineControllerStrategySyntheticKitForceKnative(t *testing.T) {
+func TestDetermineControllerStrategyNonManagedBuildForceKnative(t *testing.T) {
e := createNonManagedBuildTestEnvironment(t, v1.TraitProfileKnative)
e.Integration.Spec.Traits.KnativeService = &trait.KnativeServiceTrait{
Trait: trait.Trait{