You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "xyuanlu (via GitHub)" <gi...@apache.org> on 2023/04/11 06:02:42 UTC
[GitHub] [helix] xyuanlu opened a new pull request, #2440: force clean Znodes in after class when tests failed to clean up
xyuanlu opened a new pull request, #2440:
URL: https://github.com/apache/helix/pull/2440
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
#2395
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
When test in `TestRawZkClient` throws exception, created ZNode in those tests may not be correctly removed. Afterclass need to be able to adapt that to clean up.
### Tests
- [X] The following tests are written for this issue:
- NA
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu merged pull request #2440: Force clean Znodes in after class when tests failed to clean up
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2440:
URL: https://github.com/apache/helix/pull/2440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #2440: Force clean Znodes in after class when tests failed to clean up
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu commented on PR #2440:
URL: https://github.com/apache/helix/pull/2440#issuecomment-1505871395
This PR is ready to be merged. Approved by @desaikomal
commit messate:
Force clean Znodes in after class when tests failed to clean up in TestRawZkClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on pull request #2440: Force clean Znodes in after class when tests failed to clean up
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu commented on PR #2440:
URL: https://github.com/apache/helix/pull/2440#issuecomment-1503652109
> This kind of simple fixes if it can help stabilize our CI would be great.
>
> * Why it passes sometimes and fails sometimes any idea?
Thanks Komal for the review.
Whenever `testZkClientMonitor` fails, it did not clean up ZNode create in the test. Causing the afterClass fail as well. This PR changes afterclass so that it passes regardless of all tests passed or not.
This is the issue for `testZkClientMonitor`. It always accompany an `afterclass` failure. https://github.com/apache/helix/issues/2394
I am working on trying to fix `testZkClientMonitor` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org