You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/07/03 01:23:13 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #41822: [MINOR][SQL][TESTS] Use SystemUtils.isJavaVersionAtMost for java version check
HyukjinKwon opened a new pull request, #41822:
URL: https://github.com/apache/spark/pull/41822
### What changes were proposed in this pull request?
This PR proposes to use Apache Common API for proper Java version checking instead of manual check via `System.getProperty("java.version")`.
### Why are the changes needed?
To have the consistent codebase. This is the only place left.
### Does this PR introduce _any_ user-facing change?
No, with/without this change virtually same.
### How was this patch tested?
Manually tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #41822: [MINOR][SQL][TESTS] Use SystemUtils.isJavaVersionAtMost for java version check
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #41822: [MINOR][SQL][TESTS] Use SystemUtils.isJavaVersionAtMost for java version check
URL: https://github.com/apache/spark/pull/41822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41822: [MINOR][SQL][TESTS] Use SystemUtils.isJavaVersionAtMost for java version check
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41822:
URL: https://github.com/apache/spark/pull/41822#issuecomment-1617101071
That cannot use common3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41822: [MINOR][SQL][TESTS] Use SystemUtils.isJavaVersionAtMost for java version check
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41822:
URL: https://github.com/apache/spark/pull/41822#issuecomment-1617222502
Merged to master.
Thanks all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41822: [MINOR][SQL][TESTS] Use SystemUtils.isJavaVersionAtMost for java version check
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41822:
URL: https://github.com/apache/spark/pull/41822#issuecomment-1617097215
`org.apache.spark.util.Utils::isJavaVersionAtLeast21` shold be chnage too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #41822: [MINOR][SQL][TESTS] Use SystemUtils.isJavaVersionAtMost for java version check
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #41822:
URL: https://github.com/apache/spark/pull/41822#issuecomment-1617087312
cc @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org