You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/04/17 02:30:41 UTC
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22787
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
TestAdmissionController.test_user_loads_rules is flaky for not failing
the last query that should exceed user quota. The test execute query in
round robin fashion across all impalad. These impalads are expected to
synchronize user quota count thorugh statestore update.
This patch attempt to deflake the test by raising the heartbeat wait
time from 1 heartbeat period to 3 hearbeat period. It also change the
reject query to a fast version of SLOW_QUERY (without sleep) so test can
fail fast if it is not rejected.
Testing:
Loop the test 50 times and pass all.
Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/22787/1
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22787 )
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11753/
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Apr 2025 00:34:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22787
to look at the new patch set (#2).
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
TestAdmissionController.test_user_loads_rules is flaky for not failing
the last query that should exceed the user quota. The test executes
queries in a round-robin fashion across all impalad. These impalads are
expected to synchronize user quota count through statestore updates.
This patch attempts to deflake the test by raising the heartbeat wait
time from 1 heartbeat period to 3 hearbeat periods. It also changes the
reject query to a fast version of SLOW_QUERY (without sleep) so the test
can fail fast if it is not rejected.
Testing:
Loop the test 50 times and pass them all.
Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/22787/2
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22787 )
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
TestAdmissionController.test_user_loads_rules is flaky for not failing
the last query that should exceed the user quota. The test executes
queries in a round-robin fashion across all impalad. These impalads are
expected to synchronize user quota count through statestore updates.
This patch attempts to deflake the test by raising the heartbeat wait
time from 1 heartbeat period to 3 hearbeat periods. It also changes the
reject query to a fast version of SLOW_QUERY (without sleep) so the test
can fail fast if it is not rejected.
Testing:
Loop the test 50 times and pass them all.
Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Reviewed-on: http://gerrit.cloudera.org:8080/22787
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Riza Suminto <ri...@cloudera.com>
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Riza Suminto: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22787 )
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18940/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 02:57:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22787 )
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
Patch Set 5: Verified+1
Carry vote from tip of chain.
See https://gerrit.cloudera.org/c/22785/5#message-3b619c83_9fd58913.
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Apr 2025 15:26:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22787 )
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
Patch Set 3: Code-Review+2
Carry +2.
I think it is save to merge this chain together.
I'll try do that to save time.
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 17:55:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22787 )
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 16:49:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22787 )
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
Patch Set 2: Code-Review+1
This looks good to me. I would go to +2
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 16:21:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22787 )
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
Patch Set 5: Code-Review+2
Carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Apr 2025 01:47:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13971: Deflake TestAdmissionController.test user loads rules
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22787 )
Change subject: IMPALA-13971: Deflake TestAdmissionController.test_user_loads_rules
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11753/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ae8e1c2edf174edbf0e351d3c2ed06a0539f08
Gerrit-Change-Number: 22787
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 Apr 2025 17:55:32 +0000
Gerrit-HasComments: No