[GitHub] [libcloud] palashgandhi opened a new pull request #1300: ec2 list_volumes should accept more filters

[GitBox <gi...@apache.org>]

palashgandhi opened a new pull request #1300: ec2 list_volumes should accept more filters
URL: https://github.com/apache/libcloud/pull/1300
 
 
   ## ec2 list_volumes should accept more filters
   
   ### Description
   
   EC2 API requests are throttled which sometimes requires the API requests to be more fine tuned to avoid having to get back large amounts of responses. For more information, see this [the AWS API reference](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/query-api-troubleshooting.html#api-request-rate).
   
   This change adds the ability to pass more filters to the EC2 DescribeVolumes call, the filter needs to be a dictionary of filter name and value pairs as described [here](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeVolumes.html).
   
   I had 2 options here:
   1. Remove the `node` parameter from this call and ensure that the caller passes in the node ID as part of the `filters` dict.
   2. Add a new parameter `filters` and leave the `node` parameter as it is in order to preserve the original method signature.
   
   I chose the latter only for the reason that it preserves the original method signature.
   
   ### Status
   
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [x ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
   - [ x] Documentation
   - [ x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services