You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "ClaireLytt (via GitHub)" <gi...@apache.org> on 2026/08/01 06:04:02 UTC
[PR] Support parsing Oracle CREATE INDEXTYPE sql [shardingsphere]
ClaireLytt opened a new pull request, #39302:
URL: https://github.com/apache/shardingsphere/pull/39302
for https://github.com/apache/shardingsphere/issues/27027.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Oracle CREATE INDEXTYPE sql and Add CREATE INDEX/OPERATOR sql it test [shardingsphere]
Posted by "ClaireLytt (via GitHub)" <gi...@apache.org>.
ClaireLytt commented on PR #39302:
URL: https://github.com/apache/shardingsphere/pull/39302#issuecomment-5242939064
@terrymanu I have resolved conflict. Please review again. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Oracle CREATE INDEXTYPE sql and Add CREATE INDEX/OPERATOR sql it test [shardingsphere]
Posted by "ClaireLytt (via GitHub)" <gi...@apache.org>.
ClaireLytt commented on PR #39302:
URL: https://github.com/apache/shardingsphere/pull/39302#issuecomment-5180151227
@terrymanu
I have Added instanceof assertion for OracleCreateIndexTypeStatement in OracleDDLStatementAssert to verify the parser returns the correct statement type. Without this check, a mutation returning OracleDropIndexTypeStatement from visitCreateIndexType would pass all tests undetected.
Also added multiple_operators test and other sql tests in the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Oracle CREATE INDEXTYPE sql and Add CREATE INDEX/OPERATOR sql it test [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39302:
URL: https://github.com/apache/shardingsphere/pull/39302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support parsing Oracle CREATE INDEXTYPE sql and Add CREATE INDEX/OPERATOR sql it test [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39302:
URL: https://github.com/apache/shardingsphere/pull/39302#issuecomment-5242523702
Please resolve conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org