You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "laskoviymishka (via GitHub)" <gi...@apache.org> on 2026/06/23 18:30:30 UTC
[I] feat: let WriteManifest set and return v3 first_row_id [iceberg-go]
laskoviymishka opened a new issue, #1274:
URL: https://github.com/apache/iceberg-go/issues/1274
Follow-up to #735.
`WriteManifest` still carries its pre-#735 signature and returns only `(ManifestFile, error)` — it forwards no writer or file options, so `ToManifestFile` never sets `FirstRowIDValue` and the returned `ManifestFile.FirstRowID()` is always nil. The real v3 path (`NewManifestListWriterV3` plus the inheritance logic) handles `first_row_id`, but it's reached through `WriteManifestList`, bypassing `WriteManifest` entirely. `WriteManifest` has no production callers — it's a public helper for library consumers, who currently can neither set nor observe `first_row_id` through it, and there's no `WriteManifestV3`.
Either add a `WriteManifestV3` helper that takes a `firstRowID` and returns the assigned value alongside the `ManifestFile`, or add a `WithManifestFileFirstRowID` option and forward variadic opts through `WriteManifest`. Keep `WriteManifest` back-compatible.
This one touches public API, so it's worth a quick maintainer nod on the shape before someone runs with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] feat: let WriteManifest set and return v3 first_row_id [iceberg-go]
Posted by "the-onewho-knocks (via GitHub)" <gi...@apache.org>.
the-onewho-knocks commented on issue #1274:
URL: https://github.com/apache/iceberg-go/issues/1274#issuecomment-4806866105
Hi! I'd like to work on this issue if it's still available. My current plan is to implement the variadic options approach while keeping `WriteManifest` backward compatible, unless maintainers would prefer the `WriteManifestV3` approach. Please let me know if that direction looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] feat: let WriteManifest set and return v3 first_row_id [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka closed issue #1274: feat: let WriteManifest set and return v3 first_row_id
URL: https://github.com/apache/iceberg-go/issues/1274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org