[jira] [Commented] (HBASE-23659) BaseLoadBalancer#wouldLowerAvailability should consider region replicas

["Guanghao Zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010594#comment-17010594 ] 

Guanghao Zhang commented on HBASE-23659:
----------------------------------------

Found a bug when try to fix this. The primary index may be -1... Then wouldLowerAvailability will always return true.

 
{code:java}
int primary = regionIndexToPrimaryIndex[region]; // may be -1

if (contains(primariesOfRegionsPerServer[server], primary)) {
  // check for whether there are other servers that we can place this region
  for (int i = 0; i < primariesOfRegionsPerServer.length; i++) {
    if (i != server && !contains(primariesOfRegionsPerServer[i], primary)) {
      LOG.debug("Better server return true, region " + regionInfo + " server " + serverName);
      return true; // meaning there is a better server
    }
  }
  LOG.debug("No better server return false, region " + regionInfo + " server " + serverName);
  return false; // there is not a better server to place this
}
{code}
 

> BaseLoadBalancer#wouldLowerAvailability should consider region replicas
> -----------------------------------------------------------------------
>
>                 Key: HBASE-23659
>                 URL: https://issues.apache.org/jira/browse/HBASE-23659
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Guanghao Zhang
>            Priority: Major
>
> Found this issue when try to fix the flaky unit test  TestRegionReplicaSplit. It may fail as 
> java.lang.AssertionError: Splitted regions should not be assigned to same region server.
> See [https://builds.apache.org/job/HBase-Flaky-Tests/job/master/5227/testReport/junit/org.apache.hadoop.hbase.master.assignment/TestRegionReplicaSplit/testRegionReplicaSplitRegionAssignment/].
>  
> Now  wouldLowerAvailability method only consider the primary regions. The replica region can't assign to same server with primary region. But can be assigned to same server with other replica regions. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)