You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@amoro.apache.org by "j1wonpark (via GitHub)" <gi...@apache.org> on 2026/05/28 03:00:50 UTC

Re: [PR] [ams] Force ReachableFileCleanup when snapshots exist outside main ancestry [amoro]

j1wonpark commented on PR #4231:
URL: https://github.com/apache/amoro/pull/4231#issuecomment-4560478831

   Hi @xxubai @zhoujinsong — when you have a moment, could you take a look at this PR?
   
   This is a small, targeted backport of [apache/iceberg#13614](https://github.com/apache/iceberg/pull/13614) (shipped in Iceberg 1.10.0) to the Amoro layer, so users on Iceberg 1.6.x–1.9.x are protected from the silent data-file deletion when snapshots exist outside the main ancestry. The fix only adds a pre-commit check; healthy tables keep the existing `IncrementalFileCleanup` path, so there's no cost impact for the common case. A regression test (`TestExpireSnapshotsKeepReferencedFiles`) is included.
   
   Happy to address any feedback. Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org