You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/27 19:40:06 UTC

Review Request 70966: Test for removing a role from both roles and suppressed roles.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70966/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9870
    https://issues.apache.org/jira/browse/MESOS-9870


Repository: mesos


Description
-------

Test for removing a role from both roles and suppressed roles.


Diffs
-----

  src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f 


Diff: https://reviews.apache.org/r/70966/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko

Re: Review Request 70966: Test for removing a role from both roles and suppressed roles.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70966/#review216209
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master/update_framework_tests.cpp
Lines 687 (patched)
<https://reviews.apache.org/r/70966/#comment303305>

    Unused?



src/tests/master/update_framework_tests.cpp
Lines 701 (patched)
<https://reviews.apache.org/r/70966/#comment303313>

    Remove newline


- Benjamin Mahler


On June 27, 2019, 7:40 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70966/
> -----------------------------------------------------------
> 
> (Updated June 27, 2019, 7:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9870
>     https://issues.apache.org/jira/browse/MESOS-9870
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Test for removing a role from both roles and suppressed roles.
> 
> 
> Diffs
> -----
> 
>   src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f 
> 
> 
> Diff: https://reviews.apache.org/r/70966/diff/1/
> 
> 
> Testing
> -------
> 
> without fix: fails
> with fix: `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkTest.RemoveAndUnsuppress*" --gtest_break_on_failure --gtest_repeat=1000`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70966: Test for removing a role from both roles and suppressed roles.

Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70966/
-----------------------------------------------------------

(Updated July 2, 2019, 7:14 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9870
    https://issues.apache.org/jira/browse/MESOS-9870


Repository: mesos


Description
-------

Test for removing a role from both roles and suppressed roles.


Diffs (updated)
-----

  src/tests/master/update_framework_tests.cpp 6ee7b20194d2af4216c064b44eb1b5e8f8441145 


Diff: https://reviews.apache.org/r/70966/diff/3/

Changes: https://reviews.apache.org/r/70966/diff/2-3/


Testing
-------

without fix: fails
with fix: `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkTest.RemoveAndUnsuppress*" --gtest_break_on_failure --gtest_repeat=1000`


Thanks,

Andrei Sekretenko

Re: Review Request 70966: Test for removing a role from both roles and suppressed roles.

Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70966/
-----------------------------------------------------------

(Updated June 29, 2019, 12:53 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Bugs: MESOS-9870
    https://issues.apache.org/jira/browse/MESOS-9870


Repository: mesos


Description
-------

Test for removing a role from both roles and suppressed roles.


Diffs (updated)
-----

  src/tests/master/update_framework_tests.cpp 0d466e286adfd829bbe72cff9202860f7fcb043f 


Diff: https://reviews.apache.org/r/70966/diff/2/

Changes: https://reviews.apache.org/r/70966/diff/1-2/


Testing
-------

without fix: fails
with fix: `./bin/mesos-tests.sh --gtest_filter="UpdateFrameworkTest.RemoveAndUnsuppress*" --gtest_break_on_failure --gtest_repeat=1000`


Thanks,

Andrei Sekretenko