You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/11 16:21:45 UTC

[GitHub] [shardingsphere] zhaojinchao95 opened a new issue, #20932: ProxyClusterContainerConfigurationFactory not get cluster server.yaml configuration

zhaojinchao95 opened a new issue, #20932:
URL: https://github.com/apache/shardingsphere/issues/20932

   ### Which version of ShardingSphere did you use?
   
   `master` https://github.com/apache/shardingsphere/commit/f7e511be1b976124e327a3a0f93315552b08d895
   
   ### Which project did you use? 
   
   `shardingsphere-test`
   
   ### Expected behavior
   
   `shardingsphere-integration-test-suite` test case can run really in cluster mode.
   
   ### Actual behavior
   
   <img width="737" alt="image" src="https://user-images.githubusercontent.com/33742097/189538222-daaf3be1-b1fc-4da9-b6a5-dbaa47630e72.png">
   
   
   
   ### Reason analyze (If you can)
   
   ```
   @NoArgsConstructor(access = AccessLevel.PRIVATE)
   public final class ProxyClusterContainerConfigurationFactory {
       
       /**
        * Create instance of adaptor container configuration.
        * 
        * @param scenario scenario
        * @param databaseType database type
        * @return created instance
        */
       public static AdaptorContainerConfiguration newInstance(final String scenario, final DatabaseType databaseType) {
           return new AdaptorContainerConfiguration(scenario, getMountedResources(scenario, databaseType));
       }
       
       private static Map<String, String> getMountedResources(final String scenario, final DatabaseType databaseType) {
           Map<String, String> result = new HashMap<>(2, 1);
           String pathInContainer = "/opt/shardingsphere-proxy/conf";
           result.put("/env/common/standalone/proxy/conf/", pathInContainer);
           result.put("/env/scenario/" + scenario + "/proxy/conf/" + databaseType.getType().toLowerCase(), pathInContainer);
           return result;
       }
   }
   ```
   
   `/env/common/standalone/proxy/conf/` should be change to `/env/common/cluster/proxy/conf/`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] closed issue #20932: ProxyClusterContainerConfigurationFactory not get cluster server.yaml configuration

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #20932: ProxyClusterContainerConfigurationFactory not get cluster server.yaml configuration
URL: https://github.com/apache/shardingsphere/issues/20932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaojinchao95 commented on issue #20932: ProxyClusterContainerConfigurationFactory not get cluster server.yaml configuration

Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on issue #20932:
URL: https://github.com/apache/shardingsphere/issues/20932#issuecomment-1246175139

   The `ddl-integration-test-cases.xml` still has two error case, Can you look this? @soulasuna . Please search `<!-- TODO Fix me -->`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] sandynz closed issue #20932: ProxyClusterContainerConfigurationFactory not get cluster server.yaml configuration

Posted by GitBox <gi...@apache.org>.
sandynz closed issue #20932: ProxyClusterContainerConfigurationFactory not get cluster server.yaml configuration
URL: https://github.com/apache/shardingsphere/issues/20932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #20932: ProxyClusterContainerConfigurationFactory not get cluster server.yaml configuration

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20932:
URL: https://github.com/apache/shardingsphere/issues/20932#issuecomment-1275439303

   Hi @zhaojinchao95 @soulasuna , could we finish this issue in 5.2.1?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] github-actions[bot] commented on issue #20932: ProxyClusterContainerConfigurationFactory not get cluster server.yaml configuration

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #20932:
URL: https://github.com/apache/shardingsphere/issues/20932#issuecomment-1272348482

   Hello , this issue has not received a reply for several days.
   This issue is supposed to be closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org