You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/27 00:07:59 UTC
[GitHub] [kafka] forlack opened a new pull request, #12691: MINOR: Small update docs/design.html grammar and typo
forlack opened a new pull request, #12691:
URL: https://github.com/apache/kafka/pull/12691
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #12691: MINOR: Small update docs/design.html grammar and typo
Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12691:
URL: https://github.com/apache/kafka/pull/12691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a diff in pull request #12691: MINOR: Small update docs/design.html grammar and typo
Posted by GitBox <gi...@apache.org>.
hachikuji commented on code in PR #12691:
URL: https://github.com/apache/kafka/pull/12691#discussion_r980626434
##########
docs/design.html:
##########
@@ -322,7 +322,7 @@ <h3 class="anchor-heading"><a id="replication" class="anchor-link"></a><a href="
Followers consume messages from the leader just as a normal Kafka consumer would and apply them to their own log. Having the followers pull from the leader has the nice property of allowing the follower to naturally
batch together log entries they are applying to their log.
<p>
- As with most distributed systems automatically handling failures requires having a precise definition of what it means for a node to be "alive." In Kafka, a special node
+ As with most distributed systems, automatically handling failures requires a precise definition for when a node is considered "alive." In Kafka, a special node
Review Comment:
Agree with the removal of "having." I am not sure about the latter half of the sentence. We're trying to suggest that the definition of liveness itself varies system by system, so we need to be precise when we talk about it. The extra emphasis in the original version seemed to convey that better. The use of "when" sounds like we're suggesting some kind of temporal uncertainty, but maybe I'm overanalyzing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org