You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Till Rohrmann (JIRA)" <ji...@apache.org> on 2019/07/26 07:13:00 UTC

[jira] [Resolved] (FLINK-13407) Fix thread visibility of checked SlotManager.failUnfulfillableRequest in StandaloneResourceManagerTest

     [ https://issues.apache.org/jira/browse/FLINK-13407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Rohrmann resolved FLINK-13407.
-----------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 1.10.0)

Fixed via
1.10.0: a4936a5e029229cee18848588efbde819532cfa8
1.9.0: 5e3ee1703bce9688f76881a6aed8a13bf049ea24

> Fix thread visibility of checked SlotManager.failUnfulfillableRequest in StandaloneResourceManagerTest
> ------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-13407
>                 URL: https://issues.apache.org/jira/browse/FLINK-13407
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Coordination
>    Affects Versions: 1.9.0
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Blocker
>             Fix For: 1.9.0
>
>
> One of the potential reasons of the test instability, described in FLINK-13242, is that the test checks _failUnfulfillableRequest_ directly in its thread but it is set in the main RPC thread of _StandaloneResourceManager#initialize_. It can lead to a potential problem with the visibility of _SlotManager.failUnfulfillableRequest_ in _StandaloneResourceManagerTest#testStartupPeriod_.
> The idea for the fix is to read _SlotManager.failUnfulfillableRequest_ in the main thread of _StandaloneResourceManager_, get future result and check in the _StandaloneResourceManagerTest.assertHappensUntil_.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)