You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Mark Struberg (JIRA)" <ji...@apache.org> on 2010/05/17 19:05:46 UTC
[jira] Commented: (OWB-375) Performance: OWB logging performs
operations when logging disabled.
[ https://issues.apache.org/jira/browse/OWB-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868280#action_12868280 ]
Mark Struberg commented on OWB-375:
-----------------------------------
Our logging needs cleanup, that for sure ;)
But I wil simply introduce a pattern and pass the parameters as variable arguments.
> Performance: OWB logging performs operations when logging disabled.
> --------------------------------------------------------------------
>
> Key: OWB-375
> URL: https://issues.apache.org/jira/browse/OWB-375
> Project: OpenWebBeans
> Issue Type: Bug
> Components: Core
> Reporter: Jacquelle Leggett
> Assignee: Gurkan Erdogdu
>
> Logging operations in OWB code are not guarded by Logger.isLoggable(..) or something similar and results in Strings being processed when logging is disabled.
> Here's an example from AbstractInjectable:
> logger.debug("Injected into bean : " + this.injectionOwnerBean.toString() + " with injection point : " + injectionPoint);
> The String concatenation above will occur whether or not logging is enabled. WebBeansLogger should be modified so that the above can be changed to:
> if(logger.isDebugEnabed())
> logger.debug("Injected into bean : " + this.injectionOwnerBean.toString() + " with injection point : " + injectionPoint);
>
> Generally speaking, it's best for logging statements to be guarded by an isEnabled() flag to prevent performance impacts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.