You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/05/20 22:40:02 UTC
Review Request 47678: Preventing the sequence logger from launching
and closing a thread
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47678/
-----------------------------------------------------------
Review request for geode and Scott Jewell.
Repository: geode
Description
-------
The sequence logger code was launching a thread from a static block, even if it was not enabled. The thread was then immediately dying. Fixing the code to not launch the thread unless it is enabled, and to not die immediately if it is.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/sequencelog/SequenceLoggerImpl.java 26c944eafbe68ee0f59a90c79d2330db219f3265
Diff: https://reviews.apache.org/r/47678/diff/
Testing
-------
running precheckin
Thanks,
Dan Smith
Re: Review Request 47678: Preventing the sequence logger from
launching and closing a thread
Posted by Scott Jewell <sj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47678/#review134643
-----------------------------------------------------------
Ship it!
Ship It!
- Scott Jewell
On May 20, 2016, 10:40 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47678/
> -----------------------------------------------------------
>
> (Updated May 20, 2016, 10:40 p.m.)
>
>
> Review request for geode and Scott Jewell.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The sequence logger code was launching a thread from a static block, even if it was not enabled. The thread was then immediately dying. Fixing the code to not launch the thread unless it is enabled, and to not die immediately if it is.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/sequencelog/SequenceLoggerImpl.java 26c944eafbe68ee0f59a90c79d2330db219f3265
>
> Diff: https://reviews.apache.org/r/47678/diff/
>
>
> Testing
> -------
>
> running precheckin
>
>
> Thanks,
>
> Dan Smith
>
>