You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2015/06/05 06:12:02 UTC
[GitHub] storm pull request: STORM-850 Convert storm-core's logback-test.xm...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/579
STORM-850 Convert storm-core's logback-test.xml to log4j2-test.xml
In order to prevent Travis CI complaining about log exceeding, we need to apply this.
Please review and comment. Thanks in advance!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-850
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/579.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #579
----
commit 4ca39f15eea4ca8c3853f82cf00574babd47c963
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2015-06-05T04:08:11Z
STORM-850 Convert storm-core's logback-test.xml to log4j2-test.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-850 Convert storm-core's logback-test.xm...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/579
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-850 Convert storm-core's logback-test.xm...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/579#issuecomment-109367925
+1 No objections for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-850 Convert storm-core's logback-test.xm...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/579#issuecomment-109367168
This is just config changes, not code and it is only for testing so I am going to merge this in without waiting the full 24 hours. If others object I will be happy to revert the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-850 Convert storm-core's logback-test.xm...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/579#issuecomment-109294692
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-850 Convert storm-core's logback-test.xm...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/579#issuecomment-109349564
+1, and it seems this should be merged in together with https://github.com/apache/storm/pull/562
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---