You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2018/12/22 03:59:29 UTC
Review Request 69626: RANGER-2312 Users should have permission to
modify their personal information in User Profile page.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69626/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, sam rome, Venkat Ranganathan, and Velmurugan Periasamy.
Bugs: RANGER-2312
https://issues.apache.org/jira/browse/RANGER-2312
Repository: ranger
Description
-------
Auditor role users cannot modify their personal user profile.
User role and KMSAuditor role users have the same problem.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js 5ebd29048
Diff: https://reviews.apache.org/r/69626/diff/1/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 69626: RANGER-2312 Internal users should have
permission to modify their personal information in User Profile page.
Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69626/#review211673
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java
Line 211 (original), 211 (patched)
<https://reviews.apache.org/r/69626/#comment297128>
Can you please validate and make sure that API behaves same way (for updating user's own details) : from UI as well as from curl calls?
- Mehul Parikh
On Dec. 22, 2018, 3:59 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69626/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2018, 3:59 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, sam rome, Venkat Ranganathan, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2312
> https://issues.apache.org/jira/browse/RANGER-2312
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Auditor role users cannot modify their personal user profile.
> User role and KMSAuditor role users have the same problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
> security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js 5ebd29048
> security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 202a113d8
>
>
> Diff: https://reviews.apache.org/r/69626/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 69626: RANGER-2312 Internal users should have
permission to modify their personal information in User Profile page.
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On 十二月 25, 2018, 2:36 a.m., Don Bosco Durai wrote:
> > security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java
> > Line 211 (original), 211 (patched)
> > <https://reviews.apache.org/r/69626/diff/2/?file=2116199#file2116199line211>
> >
> > Please verify. It seems, users would be able to provide higher role to himself/herself.
In 'updateRoles(userProfile.getId(),userProfile.getUserRoleList())',
'xUserMgr.checkAccessRoles(stringRolesList)' and 'rangerBizUtil.blockAuditorRoleUser()' will check access, so AuditorRole user and UserRole user can not update roles, will return 403 forbidden.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69626/#review211530
-----------------------------------------------------------
On 十二月 22, 2018, 3:59 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69626/
> -----------------------------------------------------------
>
> (Updated 十二月 22, 2018, 3:59 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, sam rome, Venkat Ranganathan, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2312
> https://issues.apache.org/jira/browse/RANGER-2312
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Auditor role users cannot modify their personal user profile.
> User role and KMSAuditor role users have the same problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
> security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js 5ebd29048
> security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 202a113d8
>
>
> Diff: https://reviews.apache.org/r/69626/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 69626: RANGER-2312 Internal users should have
permission to modify their personal information in User Profile page.
Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69626/#review211530
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java
Line 211 (original), 211 (patched)
<https://reviews.apache.org/r/69626/#comment296828>
Please verify. It seems, users would be able to provide higher role to himself/herself.
- Don Bosco Durai
On Dec. 22, 2018, 3:59 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69626/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2018, 3:59 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, sam rome, Venkat Ranganathan, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2312
> https://issues.apache.org/jira/browse/RANGER-2312
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Auditor role users cannot modify their personal user profile.
> User role and KMSAuditor role users have the same problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
> security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js 5ebd29048
> security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 202a113d8
>
>
> Diff: https://reviews.apache.org/r/69626/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 69626: RANGER-2312 Internal users should have
permission to modify their personal information in User Profile page.
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69626/#review211618
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java
Line 211 (original), 211 (patched)
<https://reviews.apache.org/r/69626/#comment296971>
Auditor role users should not be able to update. Please check this.
- Velmurugan Periasamy
On Dec. 22, 2018, 3:59 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69626/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2018, 3:59 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, sam rome, Venkat Ranganathan, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2312
> https://issues.apache.org/jira/browse/RANGER-2312
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Auditor role users cannot modify their personal user profile.
> User role and KMSAuditor role users have the same problem.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 9e457826e
> security-admin/src/main/webapp/scripts/views/user/UserProfileForm.js 5ebd29048
> security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 202a113d8
>
>
> Diff: https://reviews.apache.org/r/69626/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>