You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by abhinandanprateek <gi...@git.apache.org> on 2017/02/22 06:50:26 UTC

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

GitHub user abhinandanprateek opened a pull request:

    https://github.com/apache/cloudstack/pull/1958

    CLOUDSTACK-5806: add presetup to storage types that support over prov\u2026

    \u2026isioning
    
    Ideally this should be configurable via global settings

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-5806

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1958.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1958
    
----
commit 6ad3429085abf2943ff3183288b7f2e7e0165963
Author: Abhinandan Prateek <ap...@apache.org>
Date:   2017-02-22T06:48:35Z

    CLOUDSTACK-5806: add presetup to storage types that support over provisioning
    Ideally this should be configurable via global settings

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    <b>Trillian test result (tid-899)</b>
    Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 31181 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1958-t899-kvm-centos7.zip
    Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
    Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
    Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
    Test completed. 47 look ok, 2 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_04_rvpc_privategw_static_routes | `Failure` | 304.33 | test_privategw_acl.py
    test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | test_snapshots.py
    test_01_vpc_site2site_vpn | Success | 144.36 | test_vpc_vpn.py
    test_01_vpc_remote_access_vpn | Success | 60.88 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 230.23 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 248.04 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 451.81 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 509.74 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1386.69 | test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 516.32 | test_vpc_redundant.py
    test_02_redundant_VPC_default_routes | Success | 727.69 | test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1271.79 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 156.45 | test_volumes.py
    test_08_resize_volume | Success | 156.13 | test_volumes.py
    test_07_resize_fail | Success | 161.18 | test_volumes.py
    test_06_download_detached_volume | Success | 156.01 | test_volumes.py
    test_05_detach_volume | Success | 150.57 | test_volumes.py
    test_04_delete_attached_volume | Success | 145.93 | test_volumes.py
    test_03_download_attached_volume | Success | 156.04 | test_volumes.py
    test_02_attach_volume | Success | 88.92 | test_volumes.py
    test_01_create_volume | Success | 710.90 | test_volumes.py
    test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Success | 95.65 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Success | 128.71 | test_vm_snapshots.py
    test_deploy_vm_multiple | Success | 262.11 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 26.52 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 125.20 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 35.71 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 125.76 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 125.67 | test_vm_life_cycle.py
    test_02_start_vm | Success | 10.12 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 35.23 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 30.33 | test_templates.py
    test_08_list_system_templates | Success | 0.03 | test_templates.py
    test_07_list_public_templates | Success | 0.02 | test_templates.py
    test_05_template_permissions | Success | 0.04 | test_templates.py
    test_04_extract_template | Success | 5.12 | test_templates.py
    test_03_delete_template | Success | 5.09 | test_templates.py
    test_02_edit_template | Success | 90.14 | test_templates.py
    test_01_create_template | Success | 30.30 | test_templates.py
    test_10_destroy_cpvm | Success | 161.54 | test_ssvm.py
    test_09_destroy_ssvm | Success | 163.44 | test_ssvm.py
    test_08_reboot_cpvm | Success | 101.26 | test_ssvm.py
    test_07_reboot_ssvm | Success | 133.44 | test_ssvm.py
    test_06_stop_cpvm | Success | 131.35 | test_ssvm.py
    test_05_stop_ssvm | Success | 133.54 | test_ssvm.py
    test_04_cpvm_internals | Success | 0.95 | test_ssvm.py
    test_03_ssvm_internals | Success | 3.31 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 10.95 | test_snapshots.py
    test_04_change_offering_small | Success | 204.34 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.12 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
    test_09_reboot_router | Success | 30.20 | test_routers.py
    test_08_start_router | Success | 25.20 | test_routers.py
    test_07_stop_router | Success | 10.13 | test_routers.py
    test_06_router_advanced | Success | 0.04 | test_routers.py
    test_05_router_basic | Success | 0.03 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.58 | test_routers.py
    test_03_restart_network_cleanup | Success | 50.35 | test_routers.py
    test_02_router_internal_adv | Success | 0.83 | test_routers.py
    test_01_router_internal_basic | Success | 0.44 | test_routers.py
    test_router_dns_guestipquery | Success | 76.65 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.04 | test_router_dns.py
    test_router_dhcphosts | Success | 275.92 | test_router_dhcphosts.py
    test_router_dhcp_opts | Success | 21.27 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 0.06 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 145.85 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.03 | test_regions.py
    test_create_pvlan_network | Success | 5.17 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.31 | test_public_ip_range.py
    test_03_vpc_privategw_restart_vpc_cleanup | Success | 448.13 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 348.72 | test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 76.68 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 35.71 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.15 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.34 | test_portable_publicip.py
    test_isolate_network_password_server | Success | 58.85 | test_password_server.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.09 | test_over_provisioning.py
    test_oobm_zchange_password | Success | 30.58 | test_outofbandmanagement.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.59 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 5.17 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.24 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.25 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.24 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.26 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.25 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 82.30 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.12 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 5.13 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.08 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.06 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.06 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 23.32 | test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.25 | test_non_contigiousvlan.py
    test_01_nic | Success | 403.05 | test_nic.py
    test_releaseIP | Success | 146.72 | test_network.py
    test_reboot_router | Success | 413.01 | test_network.py
    test_public_ip_user_account | Success | 10.22 | test_network.py
    test_public_ip_admin_account | Success | 40.24 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.74 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.61 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 123.96 | test_network.py
    test_delete_account | Success | 257.00 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.50 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 109.62 | test_network.py
    test_nic_secondaryip_add_remove | Success | 202.08 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 17.85 | test_login.py
    test_assign_and_removal_lb | Success | 133.42 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 187.08 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 217.67 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.04 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.03 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.04 | test_iso.py
    test_05_iso_permissions | Success | 0.05 | test_iso.py
    test_04_extract_Iso | Success | 5.12 | test_iso.py
    test_03_delete_iso | Success | 95.21 | test_iso.py
    test_02_edit_iso | Success | 0.04 | test_iso.py
    test_01_create_iso | Success | 20.70 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 182.45 | test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 118.28 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 483.50 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 413.33 | test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.37 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.10 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 5.82 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 5.67 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 5.59 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 5.62 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 5.67 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 5.72 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 10.66 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 5.60 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 10.62 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 5.60 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 5.59 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 7.00 | test_dynamicroles.py
    test_role_account_acls | Success | 7.00 | test_dynamicroles.py
    test_default_role_deletion | Success | 5.67 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.06 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.09 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 20.50 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 20.44 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 60.51 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 30.43 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 40.51 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 5.64 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 5.66 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 196.83 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 206.79 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 50.73 | test_affinity_groups.py
    test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
    test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
    test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
    test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
    test_3d_gpu_support | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @abhinandanprateek I think we hit an issue with the test: 
    
    ```
      File "/marvin/tests/smoke/test_over_provisioning.py", line 83, in test_UpdateStorageOverProvisioningFactor
    
    CloudstackAPIException: Execute cmd: updateconfiguration failed, due to: errorCode: 431, errorText:Unable to update  storage pool with id 2. Overprovision not supported for NetworkFilesystem
    -------------------- >> begin captured stdout << ---------------------
    === TestName: test_UpdateStorageOverProvisioningFactor | Status : EXCEPTION ===
    ```
    Reading the code changes looks like over provisioning is not supported for NFS, if that's expected we should edit the test I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @borisstoyanov a condition got inverted by the change (serg38 pointed that out above), it is fixed now. Can you rerun the tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1958


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    /cc @karuturi ready for merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

Posted by abhinandanprateek <gi...@git.apache.org>.
Github user abhinandanprateek commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1958#discussion_r102918123
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -508,7 +507,7 @@ public String updateConfiguration(final long userId, final String name, final St
                         throw new InvalidParameterValueException("unable to find storage pool by id " + resourceId);
                     }
                     if(name.equals(CapacityManager.StorageOverprovisioningFactor.key())) {
    -                    if(pool.getPoolType() != StoragePoolType.NetworkFilesystem && pool.getPoolType() != StoragePoolType.VMFS) {
    +                    if(pool.getPoolType().supportsOverProvisioning() ) {
    --- End diff --
    
    yep ! thanks @serg38 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1958#discussion_r102753237
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -508,7 +507,7 @@ public String updateConfiguration(final long userId, final String name, final St
                         throw new InvalidParameterValueException("unable to find storage pool by id " + resourceId);
                     }
                     if(name.equals(CapacityManager.StorageOverprovisioningFactor.key())) {
    -                    if(pool.getPoolType() != StoragePoolType.NetworkFilesystem && pool.getPoolType() != StoragePoolType.VMFS) {
    +                    if(pool.getPoolType().supportsOverProvisioning() ) {
    --- End diff --
    
    I believe it should be negated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-534


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-524


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    Thanks @abhinandanprateek, 
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    <b>Trillian test result (tid-880)</b>
    Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 32319 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1958-t880-kvm-centos7.zip
    Intermitten failure detected: /marvin/tests/smoke/test_over_provisioning.py
    Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
    Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
    Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
    Test completed. 46 look ok, 3 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_04_rvpc_privategw_static_routes | `Failure` | 324.14 | test_privategw_acl.py
    test_02_list_snapshots_with_removed_data_store | `Error` | 0.02 | test_snapshots.py
    test_UpdateStorageOverProvisioningFactor | `Error` | 0.03 | test_over_provisioning.py
    test_UpdateStorageOverProvisioningFactor | `Error` | 0.06 | test_over_provisioning.py
    test_01_vpc_site2site_vpn | Success | 174.24 | test_vpc_vpn.py
    test_01_vpc_remote_access_vpn | Success | 65.93 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 244.48 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 298.16 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 544.33 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 511.50 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1396.46 | test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 540.72 | test_vpc_redundant.py
    test_02_redundant_VPC_default_routes | Success | 753.01 | test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1273.44 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 151.86 | test_volumes.py
    test_08_resize_volume | Success | 156.14 | test_volumes.py
    test_07_resize_fail | Success | 161.92 | test_volumes.py
    test_06_download_detached_volume | Success | 155.97 | test_volumes.py
    test_05_detach_volume | Success | 155.65 | test_volumes.py
    test_04_delete_attached_volume | Success | 145.90 | test_volumes.py
    test_03_download_attached_volume | Success | 155.99 | test_volumes.py
    test_02_attach_volume | Success | 89.75 | test_volumes.py
    test_01_create_volume | Success | 620.70 | test_volumes.py
    test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Success | 100.69 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Success | 133.91 | test_vm_snapshots.py
    test_deploy_vm_multiple | Success | 256.99 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 26.61 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 125.23 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 35.78 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 125.77 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 126.31 | test_vm_life_cycle.py
    test_02_start_vm | Success | 10.15 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 40.44 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 85.54 | test_templates.py
    test_08_list_system_templates | Success | 0.03 | test_templates.py
    test_07_list_public_templates | Success | 0.04 | test_templates.py
    test_05_template_permissions | Success | 0.05 | test_templates.py
    test_04_extract_template | Success | 5.17 | test_templates.py
    test_03_delete_template | Success | 5.08 | test_templates.py
    test_02_edit_template | Success | 90.86 | test_templates.py
    test_01_create_template | Success | 70.45 | test_templates.py
    test_10_destroy_cpvm | Success | 191.88 | test_ssvm.py
    test_09_destroy_ssvm | Success | 163.07 | test_ssvm.py
    test_08_reboot_cpvm | Success | 131.53 | test_ssvm.py
    test_07_reboot_ssvm | Success | 133.82 | test_ssvm.py
    test_06_stop_cpvm | Success | 131.30 | test_ssvm.py
    test_05_stop_ssvm | Success | 138.75 | test_ssvm.py
    test_04_cpvm_internals | Success | 0.93 | test_ssvm.py
    test_03_ssvm_internals | Success | 3.41 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.08 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.08 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 10.92 | test_snapshots.py
    test_04_change_offering_small | Success | 210.29 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.07 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.08 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
    test_09_reboot_router | Success | 35.24 | test_routers.py
    test_08_start_router | Success | 30.27 | test_routers.py
    test_07_stop_router | Success | 10.12 | test_routers.py
    test_06_router_advanced | Success | 0.04 | test_routers.py
    test_05_router_basic | Success | 0.03 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.85 | test_routers.py
    test_03_restart_network_cleanup | Success | 55.36 | test_routers.py
    test_02_router_internal_adv | Success | 1.03 | test_routers.py
    test_01_router_internal_basic | Success | 0.59 | test_routers.py
    test_router_dns_guestipquery | Success | 76.63 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.04 | test_router_dns.py
    test_router_dhcphosts | Success | 271.40 | test_router_dhcphosts.py
    test_router_dhcp_opts | Success | 21.47 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 0.05 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 130.71 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.02 | test_regions.py
    test_create_pvlan_network | Success | 5.14 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.29 | test_public_ip_range.py
    test_03_vpc_privategw_restart_vpc_cleanup | Success | 493.09 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 359.12 | test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 82.19 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 35.68 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.27 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.31 | test_portable_publicip.py
    test_isolate_network_password_server | Success | 89.51 | test_password_server.py
    test_oobm_zchange_password | Success | 30.46 | test_outofbandmanagement.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.35 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.17 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.28 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.25 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.24 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.22 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.22 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 92.16 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.11 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.06 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 5.14 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.09 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.05 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.05 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 23.28 | test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.26 | test_non_contigiousvlan.py
    test_01_nic | Success | 408.00 | test_nic.py
    test_releaseIP | Success | 166.63 | test_network.py
    test_reboot_router | Success | 417.54 | test_network.py
    test_public_ip_user_account | Success | 10.18 | test_network.py
    test_public_ip_admin_account | Success | 40.19 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.40 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.35 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 123.45 | test_network.py
    test_delete_account | Success | 256.88 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.47 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.52 | test_network.py
    test_nic_secondaryip_add_remove | Success | 202.66 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 17.72 | test_login.py
    test_assign_and_removal_lb | Success | 133.19 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 186.93 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 222.32 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.06 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.03 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.04 | test_iso.py
    test_05_iso_permissions | Success | 0.05 | test_iso.py
    test_04_extract_Iso | Success | 5.17 | test_iso.py
    test_03_delete_iso | Success | 95.18 | test_iso.py
    test_02_edit_iso | Success | 0.04 | test_iso.py
    test_01_create_iso | Success | 20.66 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 197.34 | test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 147.52 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 493.95 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 452.15 | test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.19 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.09 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 5.75 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 5.69 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 5.55 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 5.57 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 5.92 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 5.64 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 10.64 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 5.58 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 10.61 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 5.57 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 5.56 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 6.92 | test_dynamicroles.py
    test_role_account_acls | Success | 6.95 | test_dynamicroles.py
    test_default_role_deletion | Success | 5.64 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 30.42 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 20.38 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 50.42 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 10.29 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 55.52 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 5.62 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 5.64 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 206.65 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 201.64 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 85.77 | test_affinity_groups.py
    test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
    test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
    test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.02 | test_primary_storage.py
    test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py
    test_3d_gpu_support | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1958
  
    LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---