[GitHub] [ozone] rakeshadr commented on a change in pull request #2151: HDDS-5094. [FSO] Fail OM startup when turn on prefix layout with old buckets

[GitBox <gi...@apache.org>]

rakeshadr commented on a change in pull request #2151:
URL: https://github.com/apache/ozone/pull/2151#discussion_r615545995



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1115,6 +1118,9 @@ public void start() throws IOException {
     getOMMetadataLayout();
 
     metadataManager.start(configuration);
+
+    validatesBucketLayoutMismatches();

Review comment:
       > Can it be checked before starting the ratis/RPC servers? Seems to be more safe IMHO...
   
   Thanks @elek for the comment. IMHO to maintain the existing order of starting of all the services as it is and don't like to impact existing OM startup behavior due to this temporary validation logic, **by default the feature is disabled and there is no impact to the existing users/clusters**. Like I said the contributors(dev team) will be actively working to support older[simple] buckets in prefix layout and will remove this validation logic later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org