You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zjncs (via GitHub)" <gi...@apache.org> on 2026/10/09 17:25:40 UTC
[PR] test(client): pin the connection view wire shape [rocketmq-dashboard]
zjncs opened a new pull request, #5911:
URL: https://github.com/apache/rocketmq-dashboard/pull/5911
### What
`ClientConnectionVO` is a client connection row. It had no test. This adds 3 tests.
### What is pinned
- **the connection timestamp is serialized as a JSON string** — its `@JsonFormat(shape = STRING)` shape; without the annotation a `LocalDateTime` serializes as a field array like `[2026,1,2,3,4,5]`, which no client can parse;
- every identity field round-trips through the builder;
- a fresh connection is not partial.
### Verification
- New tests on unmodified code: **3/3 green**, checkstyle clean.
- Discriminating mutation: the `@JsonFormat` annotation removed (red).
- Restored: 3/3 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): pin the connection view wire shape [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] commented on PR #5911:
URL: https://github.com/apache/rocketmq-dashboard/pull/5911#issuecomment-6714914024
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(client): pin the connection view wire shape [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@rocketmq.apache.org>.
github-actions[bot] closed pull request #5911: test(client): pin the connection view wire shape
URL: https://github.com/apache/rocketmq-dashboard/pull/5911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org