You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/24 14:59:47 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #4453: Completion SET statement

terrymanu opened a new issue #4453: Completion SET statement
URL: https://github.com/apache/incubator-shardingsphere/issues/4453
 
 
   We just parse SET statement simplify, it is not enough.
   
   The SET statement is different with different dialect.
   
   Syntax of MySQL: 
   
   ```
   SET variable = expr [, variable = expr] ...
   
   variable: {
       user_var_name
     | param_name
     | local_var_name
     | {GLOBAL | @@GLOBAL.} system_var_name
     | {PERSIST | @@PERSIST.} system_var_name
     | {PERSIST_ONLY | @@PERSIST_ONLY.} system_var_name
     | [SESSION | @@SESSION. | @@] system_var_name
   }
   ```
   
   Syntax of PostgreSQL: 
   
   ```
   SET [ SESSION | LOCAL ] configuration_parameter { TO | = } { value | 'value' | DEFAULT }
   SET [ SESSION | LOCAL ] TIME ZONE { timezone | LOCAL | DEFAULT }
   ```
   
   Even they are different totally, but we still can find the same abstraction of them.
   
   The tasks of SET statement:
   
   - [ ] Parse variable name
   - [ ] Parse variable value
   - [ ] Parse scope
   - [ ] Can support set multiple variables
   - [ ] Consider about Oracle and SQLServer
   - [ ] Consider about use sub-class to split different of SET dialect

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] jingshanglu edited a comment on issue #4453: Completion of parse SET statement

Posted by GitBox <gi...@apache.org>.
jingshanglu edited a comment on issue #4453: Completion of parse SET statement
URL: https://github.com/apache/incubator-shardingsphere/issues/4453#issuecomment-590661093
 
 
   I'll support something, start from "Can support set multiple variables"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #4453: Completion of parse SET statement

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #4453: Completion of parse SET statement
URL: https://github.com/apache/incubator-shardingsphere/issues/4453#issuecomment-590682740
 
 
   @jingshanglu Great, I just assign issue to you.
   Anybody inserting, I can continue  to assign them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #4453: Completion of parse SET statement

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on issue #4453: Completion of parse SET statement
URL: https://github.com/apache/incubator-shardingsphere/issues/4453#issuecomment-590661093
 
 
   I'll support "Parse variable value" and "Can support set multiple variables"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] SteNicholas commented on issue #4453: Completion of parse SET statement

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #4453: Completion of parse SET statement
URL: https://github.com/apache/incubator-shardingsphere/issues/4453#issuecomment-590866222
 
 
   @terrymanu Please assign following two task to me:
   - Consider about Oracle and SQLServer
   - Consider about use sub-class to split different of SET dialect

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] beijing-penguin commented on issue #4453: Completion of parse SET statement

Posted by GitBox <gi...@apache.org>.
beijing-penguin commented on issue #4453: Completion of parse SET statement
URL: https://github.com/apache/incubator-shardingsphere/issues/4453#issuecomment-590738488
 
 
   I want to do Parse variable value

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services