You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "FinalT (via GitHub)" <gi...@apache.org> on 2023/04/01 06:12:12 UTC
[GitHub] [dubbo-go-samples] FinalT opened a new pull request, #551: Condition Example
FinalT opened a new pull request, #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551
Condition Example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] justxuewei commented on pull request #551: Condition Example
Posted by "justxuewei (via GitHub)" <gi...@apache.org>.
justxuewei commented on PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#issuecomment-1501048231
> Now there is a [problem](https://github.com/apache/dubbo-go/issues/2283), I don't have a good way to get the routing rules locally
I am just wondering, do the conditional rules only get from the config center, or can they also be able to set in the config file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] FinalT commented on pull request #551: Condition Example
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#issuecomment-1501035504
> Is there any way to use conditional route without config center or dubbo admin? Because doing that is a very heavy burden to the users who are new to the Dubbo-go.
I think there is a way to do it, and I will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a diff in pull request #551: Condition Example
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#discussion_r1161198119
##########
condition/README_zh.md:
##########
@@ -0,0 +1,27 @@
+# dubbo-go condition 示例
+
+可以按照下文步骤，将 Demo 部署到本地。
+
+<h2 id="target">1 条件路由介绍</h2>
Review Comment:
英文部分也一样。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a diff in pull request #551: Condition Example
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#discussion_r1161197991
##########
condition/README_zh.md:
##########
@@ -0,0 +1,27 @@
+# dubbo-go condition 示例
+
+可以按照下文步骤，将 Demo 部署到本地。
+
+<h2 id="target">1 条件路由介绍</h2>
Review Comment:
全部使用 markdown 格式，不要在其中插入 html。 by 于雨
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] FinalT commented on pull request #551: Condition Example
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#issuecomment-1501053433
> > Yes，Can be able to set in the config file
>
> Okay, could you provide an example of how to use the feature locally, as a brief guide to help users understand how it works? It's not necessary to use it with the Dubbo admin. If you believe that obtaining the rules dynamically is also an important topic, then leaving both samples would be fine with me.
>
> To summarize, keeping your examples as simple as you could.
Ok, I'll finish it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] FinalT commented on a diff in pull request #551: Condition Example
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on code in PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#discussion_r1161199405
##########
condition/README_zh.md:
##########
@@ -0,0 +1,27 @@
+# dubbo-go condition 示例
+
+可以按照下文步骤，将 Demo 部署到本地。
+
+<h2 id="target">1 条件路由介绍</h2>
Review Comment:
I will revise it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] FinalT commented on pull request #551: Condition Example
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#issuecomment-1501048457
>
> Is there any way to use conditional route without config center or dubbo admin? Because doing that is a very heavy burden to the users who are new to the Dubbo-go.
> > Now there is a [problem](https://github.com/apache/dubbo-go/issues/2283), I don't have a good way to get the routing rules locally
>
> I am just wondering, do the conditional rules only get from the config center, or can they also be able to set in the config file?
Yes，Can be able to set in the config file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] justxuewei commented on pull request #551: Condition Example
Posted by "justxuewei (via GitHub)" <gi...@apache.org>.
justxuewei commented on PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#issuecomment-1501030633
Is there any way to use conditional route without config center or dubbo admin? Because doing that is a very heavy burden to the users who are new to the Dubbo-go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] FinalT commented on pull request #551: Condition Example
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#issuecomment-1501035541
> Is there any way to use conditional route without config center or dubbo admin? Because doing that is a very heavy burden to the users who are new to the Dubbo-go.
I think there is a way to do it, and I will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] FinalT commented on pull request #551: Condition Example
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT commented on PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#issuecomment-1501043177
> Is there any way to use conditional route without config center or dubbo admin? Because doing that is a very heavy burden to the users who are new to the Dubbo-go.
Now there is a [problem](https://github.com/apache/dubbo-go/issues/2283), I don't have a good way to get the routing rules locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] justxuewei commented on pull request #551: Condition Example
Posted by "justxuewei (via GitHub)" <gi...@apache.org>.
justxuewei commented on PR #551:
URL: https://github.com/apache/dubbo-go-samples/pull/551#issuecomment-1501049239
> Yes，Can be able to set in the config file
Okay, could you provide an example of how to use the feature locally, as a brief guide to help users understand how it works? It's not necessary to use it with the Dubbo admin. If you believe that obtaining the rules dynamically is also an important topic, then leaving both samples would be fine with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] FinalT closed pull request #551: Condition Example
Posted by "FinalT (via GitHub)" <gi...@apache.org>.
FinalT closed pull request #551: Condition Example
URL: https://github.com/apache/dubbo-go-samples/pull/551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org