You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2016/03/09 08:47:00 UTC

Review Request 44558: SENTRY-1123: Add test cases for Hive, Solr, Index, Sqoop with the CommonPrivilege

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44558/
-----------------------------------------------------------

Review request for sentry.


Bugs: SENTRY-1123
    https://issues.apache.org/jira/browse/SENTRY-1123


Repository: sentry


Description
-------

Delete the test cases in TestSqoopWildcardPrivilege, TestSearchWildcardPrivilege, TestIndexerWildcardPrivilege, TestDBWildcardPrivilege. Add test cases for Hive, Solr, Index, Sqoop with the CommonPrivilege


Diffs
-----

  sentry-policy/sentry-policy-common/pom.xml c925441 
  sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java 8583448 
  sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/CommonPrivilegeTestUtil.java PRE-CREATION 
  sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilegeForHive.java PRE-CREATION 
  sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilegeForIndexer.java PRE-CREATION 
  sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilegeForSearch.java PRE-CREATION 
  sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilegeForSqoop.java PRE-CREATION 
  sentry-policy/sentry-policy-db/src/test/java/org/apache/sentry/policy/db/TestDBWildcardPrivilege.java 343a45d 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerWildcardPrivilege.java 3ecde2d 
  sentry-policy/sentry-policy-search/src/test/java/org/apache/sentry/policy/search/TestSearchWildcardPrivilege.java 688e3f8 
  sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java 8d27726 

Diff: https://reviews.apache.org/r/44558/diff/


Testing
-------


Thanks,

Colin Ma


Re: Review Request 44558: SENTRY-1123: Add test cases for Hive, Solr, Index, Sqoop with the CommonPrivilege

Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44558/#review123597
-----------------------------------------------------------


Ship it!




Ship It!

- Dapeng Sun


On 三月 11, 2016, 2:39 p.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44558/
> -----------------------------------------------------------
> 
> (Updated 三月 11, 2016, 2:39 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-1123
>     https://issues.apache.org/jira/browse/SENTRY-1123
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Delete the test cases in TestSqoopWildcardPrivilege, TestSearchWildcardPrivilege, TestIndexerWildcardPrivilege, TestDBWildcardPrivilege. Add test cases for Hive, Solr, Index, Sqoop with the CommonPrivilege
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/privilege/hive/TestCommonPrivilegeForHive.java PRE-CREATION 
>   sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/privilege/solr/TestCommonPrivilegeForSearch.java PRE-CREATION 
>   sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/privilege/sqoop/TestCommonPrivilegeForSqoop.java PRE-CREATION 
>   sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java e752c76 
>   sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java 8583448 
>   sentry-policy/sentry-policy-db/src/test/java/org/apache/sentry/policy/db/TestDBWildcardPrivilege.java 343a45d 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestCommonPrivilegeForIndexer.java PRE-CREATION 
>   sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerWildcardPrivilege.java 3ecde2d 
>   sentry-policy/sentry-policy-search/src/test/java/org/apache/sentry/policy/search/TestSearchWildcardPrivilege.java 688e3f8 
>   sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java 8d27726 
> 
> Diff: https://reviews.apache.org/r/44558/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Re: Review Request 44558: SENTRY-1123: Add test cases for Hive, Solr, Index, Sqoop with the CommonPrivilege

Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44558/
-----------------------------------------------------------

(Updated March 11, 2016, 6:39 a.m.)


Review request for sentry.


Bugs: SENTRY-1123
    https://issues.apache.org/jira/browse/SENTRY-1123


Repository: sentry


Description
-------

Delete the test cases in TestSqoopWildcardPrivilege, TestSearchWildcardPrivilege, TestIndexerWildcardPrivilege, TestDBWildcardPrivilege. Add test cases for Hive, Solr, Index, Sqoop with the CommonPrivilege


Diffs (updated)
-----

  sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/privilege/hive/TestCommonPrivilegeForHive.java PRE-CREATION 
  sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/privilege/solr/TestCommonPrivilegeForSearch.java PRE-CREATION 
  sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/privilege/sqoop/TestCommonPrivilegeForSqoop.java PRE-CREATION 
  sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java e752c76 
  sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java 8583448 
  sentry-policy/sentry-policy-db/src/test/java/org/apache/sentry/policy/db/TestDBWildcardPrivilege.java 343a45d 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestCommonPrivilegeForIndexer.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerWildcardPrivilege.java 3ecde2d 
  sentry-policy/sentry-policy-search/src/test/java/org/apache/sentry/policy/search/TestSearchWildcardPrivilege.java 688e3f8 
  sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java 8d27726 

Diff: https://reviews.apache.org/r/44558/diff/


Testing
-------


Thanks,

Colin Ma


Re: Review Request 44558: SENTRY-1123: Add test cases for Hive, Solr, Index, Sqoop with the CommonPrivilege

Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44558/
-----------------------------------------------------------

(Updated March 10, 2016, 1:47 a.m.)


Review request for sentry.


Bugs: SENTRY-1123
    https://issues.apache.org/jira/browse/SENTRY-1123


Repository: sentry


Description
-------

Delete the test cases in TestSqoopWildcardPrivilege, TestSearchWildcardPrivilege, TestIndexerWildcardPrivilege, TestDBWildcardPrivilege. Add test cases for Hive, Solr, Index, Sqoop with the CommonPrivilege


Diffs (updated)
-----

  sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/privilege/hive/TestCommonPrivilegeForHive.java PRE-CREATION 
  sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/privilege/solr/TestCommonPrivilegeForSearch.java PRE-CREATION 
  sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/privilege/sqoop/TestCommonPrivilegeForSqoop.java PRE-CREATION 
  sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java 8583448 
  sentry-policy/sentry-policy-db/src/test/java/org/apache/sentry/policy/db/TestDBWildcardPrivilege.java 343a45d 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestCommonPrivilegeForIndexer.java PRE-CREATION 
  sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerWildcardPrivilege.java 3ecde2d 
  sentry-policy/sentry-policy-search/src/test/java/org/apache/sentry/policy/search/TestSearchWildcardPrivilege.java 688e3f8 
  sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java 8d27726 

Diff: https://reviews.apache.org/r/44558/diff/


Testing
-------


Thanks,

Colin Ma