You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Yuanchi Ning <ni...@gmail.com> on 2016/04/08 02:02:12 UTC
Review Request 45912: SAMZA-0.10.0: fix the bug of SamzaObjectMapper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, otherwise it wouldn't discover the basic types like HashMap Entry
Diffs
-----
samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
Diff: https://reviews.apache.org/r/45912/diff/
Testing
-------
Thanks,
Yuanchi Ning
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/#review127925
-----------------------------------------------------------
Ship it!
- Chinmay Soman
On April 8, 2016, 11:40 p.m., Yuanchi Ning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45912/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 11:40 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, otherwise it will cause JsonSerde misbehave (wouldn't discover the basic types like HashMap Entry)
> JIRA ticket link: https://issues.apache.org/jira/browse/SAMZA-933
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
> samza-core/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala 4f1c14ce3838163c5af8c9d076238e0ed32619e1
>
> Diff: https://reviews.apache.org/r/45912/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yuanchi Ning
>
>
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/#review127927
-----------------------------------------------------------
Ship it!
lgtm thanks!
- Jagadish Venkatraman
On April 8, 2016, 11:40 p.m., Yuanchi Ning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45912/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 11:40 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, otherwise it will cause JsonSerde misbehave (wouldn't discover the basic types like HashMap Entry)
> JIRA ticket link: https://issues.apache.org/jira/browse/SAMZA-933
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
> samza-core/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala 4f1c14ce3838163c5af8c9d076238e0ed32619e1
>
> Diff: https://reviews.apache.org/r/45912/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yuanchi Ning
>
>
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Yuanchi Ning <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/
-----------------------------------------------------------
(Updated April 8, 2016, 11:40 p.m.)
Review request for samza.
Repository: samza
Description (updated)
-------
enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, otherwise it will cause JsonSerde misbehave (wouldn't discover the basic types like HashMap Entry)
JIRA ticket link: https://issues.apache.org/jira/browse/SAMZA-933
Diffs
-----
samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
samza-core/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala 4f1c14ce3838163c5af8c9d076238e0ed32619e1
Diff: https://reviews.apache.org/r/45912/diff/
Testing
-------
Thanks,
Yuanchi Ning
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/#review127922
-----------------------------------------------------------
Ship it!
Changes look good. +1 !
@Yuanchi: Can you link the JIRA number in the RB? Also, please attach the patch to JIRA so that we can commit it. Thanks!
- Navina Ramesh
On April 8, 2016, 11:18 p.m., Yuanchi Ning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45912/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 11:18 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> add test
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
> samza-core/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala 4f1c14ce3838163c5af8c9d076238e0ed32619e1
>
> Diff: https://reviews.apache.org/r/45912/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yuanchi Ning
>
>
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Yuanchi Ning <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/
-----------------------------------------------------------
(Updated April 8, 2016, 11:18 p.m.)
Review request for samza.
Repository: samza
Description
-------
add test
Diffs (updated)
-----
samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
samza-core/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala 4f1c14ce3838163c5af8c9d076238e0ed32619e1
Diff: https://reviews.apache.org/r/45912/diff/
Testing
-------
Thanks,
Yuanchi Ning
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Yuanchi Ning <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/
-----------------------------------------------------------
(Updated April 8, 2016, 11:16 p.m.)
Review request for samza.
Repository: samza
Description (updated)
-------
add test
Diffs (updated)
-----
docs/_config.yml a3bb8d48a31b5542b9a10dc3e5c741a244e0d77d
docs/_docs/replace-versioned.sh d9fb383645aafc204493c94f2eac27b5fee7f786
docs/community/committers.md 4c8426323199e05acd250d65af1f652c41d5c127
docs/contribute/tests.md c4f992407344155378fa20ac4bcb431cb2147981
docs/learn/tutorials/versioned/deploy-samza-job-from-hdfs.md c2d934d7919c82f99ede1c4b12cb450439f99e47
docs/learn/tutorials/versioned/deploy-samza-to-CDH.md b5e0397219f00ecdc900957ce70323b943dd83de
docs/learn/tutorials/versioned/index.md 8b2b69222eb6a89c514085934def9062cc63dc0c
docs/learn/tutorials/versioned/remote-debugging-samza.md efef0455ed73b2db0de512879ed02a41a571b541
docs/learn/tutorials/versioned/run-in-multi-node-yarn.md 50ac2111d30cb0e9c1725da09e40c49d380a7b9a
docs/learn/tutorials/versioned/upgrading-from-0.7.0-to-0.8.0.md 340762e71a07ecd531d071e43b180ed310ca92f1
docs/startup/download/index.md ee057140408abfd5ad896db0793d8627f6a3a10f
docs/startup/hello-samza/versioned/index.md 8fb4a94484f662272231b8fbf65f007addee8189
gradle.properties b18c0cb62aec7592e8bfb1f2aa83c6b8eada867f
samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
samza-core/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala 4f1c14ce3838163c5af8c9d076238e0ed32619e1
Diff: https://reviews.apache.org/r/45912/diff/
Testing
-------
Thanks,
Yuanchi Ning
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Navina Ramesh <nr...@linkedin.com>.
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/#review127723
-----------------------------------------------------------
On April 8, 2016, 12:02 a.m., Yuanchi Ning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45912/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 12:02 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, otherwise it wouldn't discover the basic types like HashMap Entry
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
>
> Diff: https://reviews.apache.org/r/45912/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yuanchi Ning
>
>
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Yuanchi Ning <ni...@gmail.com>.
> On April 8, 2016, 3:06 a.m., Jagadish Venkatraman wrote:
> >
Hi Jagadish, here is the JIRA ticket explaining the change https://issues.apache.org/jira/browse/SAMZA-933
- Yuanchi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/#review127723
-----------------------------------------------------------
On April 8, 2016, 11:18 p.m., Yuanchi Ning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45912/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 11:18 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> add test
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
> samza-core/src/test/scala/org/apache/samza/serializers/TestJsonSerde.scala 4f1c14ce3838163c5af8c9d076238e0ed32619e1
>
> Diff: https://reviews.apache.org/r/45912/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yuanchi Ning
>
>
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Navina Ramesh <nr...@linkedin.com>.
> On April 8, 2016, 3:06 a.m., Jagadish Venkatraman wrote:
> > samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java, line 96
> > <https://reviews.apache.org/r/45912/diff/1/?file=1331874#file1331874line96>
> >
> > Maybe, I'm missing context on this change. What is the bug that this change addresses?
> >
> > It would be really helpful if you could please explain the problem (maybe in a JIRA), and how this fixes it.
Jagadish,
I believe this is related to SAMZA-933.
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/#review127723
-----------------------------------------------------------
On April 8, 2016, 12:02 a.m., Yuanchi Ning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45912/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 12:02 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, otherwise it wouldn't discover the basic types like HashMap Entry
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
>
> Diff: https://reviews.apache.org/r/45912/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yuanchi Ning
>
>
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/#review127723
-----------------------------------------------------------
samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java
<https://reviews.apache.org/r/45912/#comment191111>
Maybe, I'm missing context on this change. What is the bug that this change addresses?
It would be really helpful if you could please explain the problem (maybe in a JIRA), and how this fixes it.
- Jagadish Venkatraman
On April 8, 2016, 12:02 a.m., Yuanchi Ning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45912/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 12:02 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, otherwise it wouldn't discover the basic types like HashMap Entry
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
>
> Diff: https://reviews.apache.org/r/45912/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yuanchi Ning
>
>
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Navina Ramesh <nr...@linkedin.com>.
> On April 8, 2016, 12:04 a.m., Chinmay Soman wrote:
> > Lets add a unit test for this.
+1 for unit test :)
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/#review127702
-----------------------------------------------------------
On April 8, 2016, 12:02 a.m., Yuanchi Ning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45912/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 12:02 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, otherwise it wouldn't discover the basic types like HashMap Entry
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
>
> Diff: https://reviews.apache.org/r/45912/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yuanchi Ning
>
>
Re: Review Request 45912: SAMZA-0.10.0: fix the bug of
SamzaObjectMapper
Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45912/#review127702
-----------------------------------------------------------
Lets add a unit test for this.
- Chinmay Soman
On April 8, 2016, 12:02 a.m., Yuanchi Ning wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45912/
> -----------------------------------------------------------
>
> (Updated April 8, 2016, 12:02 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> enable the SerializationConfig AUTO_DETECT_GETTERS in SamzaObjectMapper, otherwise it wouldn't discover the basic types like HashMap Entry
>
>
> Diffs
> -----
>
> samza-core/src/main/java/org/apache/samza/serializers/model/SamzaObjectMapper.java 717b5dcad2aa22540deb08962bf2833e7dc5baa5
>
> Diff: https://reviews.apache.org/r/45912/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yuanchi Ning
>
>