You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/01 06:40:06 UTC

[GitHub] [shardingsphere-elasticjob] lovepoem opened a new pull request #1532: Fix travis ci error

lovepoem opened a new pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532


   Fix travis ci error


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] lovepoem commented on a change in pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
lovepoem commented on a change in pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532#discussion_r498235618



##########
File path: .travis.yml
##########
@@ -1,10 +1,22 @@
 language: java
-dist: trusty
 jdk:
-  - oraclejdk8
-  #- oraclejdk7
-  #- openjdk7
+  - openjdk8
+
+install: true
+
+cache:
+  directories:
+    - "$HOME/.m2"
+
 before_script:
-    - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxPermSize=256m'" > ~/.mavenrc
+  - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxMetaspaceSize=256m'" > ~/.mavenrc
+  - rm -rf $HOME/.m2/repository/org/apache/shardingsphere/elasticjob

Review comment:
       Finished




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] lovepoem commented on a change in pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
lovepoem commented on a change in pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532#discussion_r498242653



##########
File path: pom.xml
##########
@@ -464,13 +464,6 @@
                 <version>${cobertura-maven-plugin.version}</version>
                 <configuration>
                     <check>
-                        <branchRate>80</branchRate>
-                        <lineRate>80</lineRate>
-                        <haltOnFailure>true</haltOnFailure>
-                        <totalBranchRate>80</totalBranchRate>
-                        <totalLineRate>80</totalLineRate>
-                        <packageLineRate>80</packageLineRate>
-                        <packageBranchRate>80</packageBranchRate>

Review comment:
       Reverted pom.xml




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532#discussion_r498028504



##########
File path: pom.xml
##########
@@ -28,7 +28,7 @@
     <version>3.0.0-beta-SNAPSHOT</version>
     <packaging>pom</packaging>
     <name>${project.artifactId}</name>
-    

Review comment:
       Keep indents (including blank lines) consistent with the previous one.
   Ref https://shardingsphere.apache.org/community/en/contribute/code-conduct/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] terrymanu commented on a change in pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532#discussion_r498239912



##########
File path: pom.xml
##########
@@ -464,13 +464,6 @@
                 <version>${cobertura-maven-plugin.version}</version>
                 <configuration>
                     <check>
-                        <branchRate>80</branchRate>
-                        <lineRate>80</lineRate>
-                        <haltOnFailure>true</haltOnFailure>
-                        <totalBranchRate>80</totalBranchRate>
-                        <totalLineRate>80</totalLineRate>
-                        <packageLineRate>80</packageLineRate>
-                        <packageBranchRate>80</packageBranchRate>

Review comment:
       We should not remove this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] terrymanu commented on a change in pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532#discussion_r498074095



##########
File path: .travis.yml
##########
@@ -1,10 +1,22 @@
 language: java
-dist: trusty
 jdk:
-  - oraclejdk8
-  #- oraclejdk7
-  #- openjdk7
+  - openjdk8
+
+install: true
+
+cache:
+  directories:
+    - "$HOME/.m2"
+
 before_script:
-    - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxPermSize=256m'" > ~/.mavenrc
+  - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxMetaspaceSize=256m'" > ~/.mavenrc
+  - rm -rf $HOME/.m2/repository/org/apache/shardingsphere/elasticjob

Review comment:
       Why rm folder in before script, can `mvn clean install` do it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] terrymanu commented on a change in pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532#discussion_r498220182



##########
File path: .travis.yml
##########
@@ -1,10 +1,22 @@
 language: java
-dist: trusty
 jdk:
-  - oraclejdk8
-  #- oraclejdk7
-  #- openjdk7
+  - openjdk8
+
+install: true
+
+cache:
+  directories:
+    - "$HOME/.m2"
+
 before_script:
-    - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxPermSize=256m'" > ~/.mavenrc
+  - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxMetaspaceSize=256m'" > ~/.mavenrc
+  - rm -rf $HOME/.m2/repository/org/apache/shardingsphere/elasticjob

Review comment:
       It seems like still existed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] lovepoem commented on a change in pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
lovepoem commented on a change in pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532#discussion_r498080579



##########
File path: .travis.yml
##########
@@ -1,10 +1,22 @@
 language: java
-dist: trusty
 jdk:
-  - oraclejdk8
-  #- oraclejdk7
-  #- openjdk7
+  - openjdk8
+
+install: true
+
+cache:
+  directories:
+    - "$HOME/.m2"
+
 before_script:
-    - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxPermSize=256m'" > ~/.mavenrc
+  - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxMetaspaceSize=256m'" > ~/.mavenrc
+  - rm -rf $HOME/.m2/repository/org/apache/shardingsphere/elasticjob

Review comment:
       Removed useless code




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532#issuecomment-702220467


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532?src=pr&el=h1) Report
   > Merging [#1532](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/e7af3f79c0264da518e90530b09f487e5fecd1a4?el=desc) will **increase** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1532      +/-   ##
   ============================================
   + Coverage     85.36%   85.40%   +0.03%     
   + Complexity      102      101       -1     
   ============================================
     Files           245      245              
     Lines          5666     5666              
     Branches        892      892              
   ============================================
   + Hits           4837     4839       +2     
   - Misses          517      518       +1     
   + Partials        312      309       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-3.18%)` | `1.00% <0.00%> (ø%)` | |
   | [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-3.08%)` | `0.00% <0.00%> (ø%)` | |
   | [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `72.44% <0.00%> (-0.79%)` | `32.00% <0.00%> (-1.00%)` | |
   | [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `100.00% <0.00%> (+4.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ener/AbstractDistributeOnceElasticJobListener.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL2xpc3RlbmVyL0Fic3RyYWN0RGlzdHJpYnV0ZU9uY2VFbGFzdGljSm9iTGlzdGVuZXIuamF2YQ==) | `81.48% <0.00%> (+7.40%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/elasticjob/lite/internal/server/ServerNode.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2VydmVyL1NlcnZlck5vZGUuamF2YQ==) | `100.00% <0.00%> (+20.00%)` | `0.00% <0.00%> (ø%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532?src=pr&el=footer). Last update [e7af3f7...54ad462](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1532?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] lovepoem commented on a change in pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
lovepoem commented on a change in pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532#discussion_r498080579



##########
File path: .travis.yml
##########
@@ -1,10 +1,22 @@
 language: java
-dist: trusty
 jdk:
-  - oraclejdk8
-  #- oraclejdk7
-  #- openjdk7
+  - openjdk8
+
+install: true
+
+cache:
+  directories:
+    - "$HOME/.m2"
+
 before_script:
-    - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxPermSize=256m'" > ~/.mavenrc
+  - echo "MAVEN_OPTS='-Xmx1024m -XX:MaxMetaspaceSize=256m'" > ~/.mavenrc
+  - rm -rf $HOME/.m2/repository/org/apache/shardingsphere/elasticjob

Review comment:
       remove useless code




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1532: Fix travis ci error and change coverage platform to codecov

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1532:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1532


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org