You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/09 04:05:36 UTC
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9971: [Bugfix] Fix the bug data balance causes tablet loss
morningman commented on code in PR #9971:
URL: https://github.com/apache/incubator-doris/pull/9971#discussion_r893042637
##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1655,4 +1655,11 @@ public class Config extends ConfigBase {
@ConfField(mutable = false, masterOnly = true)
public static int backend_rpc_timeout_ms = 60000; // 1 min
+ /**
+ * If set to TRUE, FE will rebalance tablets on BE frequently.
+ * It's used to test the reliability in single replica case when tablet scheduling are frequent.
+ * Default is false.
+ */
+ @ConfField
Review Comment:
```suggestion
@ConfField(mutable = false, masterOnly = true)
```
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -471,8 +472,36 @@ Status TabletManager::_drop_tablet_unlocked(TTabletId tablet_id, bool keep_files
<< "tablet_id=" << tablet_id;
return Status::OK();
}
+ if (to_drop_tablet->replica_id() != replica_id && replica_id != 0) {
+ LOG(WARNING) << "fail to drop tablet because replica_id not match. "
+ << "tablet_id=" << tablet_id;
Review Comment:
print `replica_id` as well.
##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1655,4 +1655,11 @@ public class Config extends ConfigBase {
@ConfField(mutable = false, masterOnly = true)
public static int backend_rpc_timeout_ms = 60000; // 1 min
+ /**
+ * If set to TRUE, FE will rebalance tablets on BE frequently.
+ * It's used to test the reliability in single replica case when tablet scheduling are frequent.
+ * Default is false.
+ */
+ @ConfField
Review Comment:
And please add comment to explain more about how this works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org