[jira] [Created] (LUCENE-8906) Lucene50PostingsReader.postings() casts BlockTermState param to private IntBlockTermState

["Bruno Roustant (JIRA)" <ji...@apache.org>]

Bruno Roustant created LUCENE-8906:
--------------------------------------

             Summary: Lucene50PostingsReader.postings() casts BlockTermState param to private IntBlockTermState
                 Key: LUCENE-8906
                 URL: https://issues.apache.org/jira/browse/LUCENE-8906
             Project: Lucene - Core
          Issue Type: Improvement
          Components: core/codecs
            Reporter: Bruno Roustant


Lucene50PostingsReader is the public API that offers the postings() method to read the postings. Any PostingFormat can use it (as well as Lucene50PostingsWriter) to read/write postings.

But the postings() method asks for a (public) BlockTermState param which is internally cast to the private IntBlockTermState. This BlockTermState is provided by Lucene50PostingsReader.newTermState().

public PostingsEnum postings(FieldInfo fieldInfo, BlockTermState termState, PostingsEnum reuse, int flags)

This actually makes impossible to a custom PostingFormat customizing the Block file structure to use this postings() method by providing their (Int)BlockTermState, because they cannot access the FP fields of the IntBlockTermState returned by PostingsReaderBase.newTermState().

Proposed change:
 * Either make IntBlockTermState public, as well as its fields.
 * Or replace it by an interface in the postings() method. In this case the IntBlockTermState fields currently accessed directly would be replaced by getter/setter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org